Commit 449a66fd authored by Richard Weinberger's avatar Richard Weinberger Committed by Frederic Weisbecker
Browse files

x86: Remove warning and warning_symbol from struct stacktrace_ops 



Both warning and warning_symbol are nowhere used.
Let's get rid of them.

Signed-off-by: default avatarRichard Weinberger <richard@nod.at>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Huang Ying <ying.huang@intel.com>
Cc: Soeren Sandmann Pedersen <ssp@redhat.com>
Cc: Namhyung Kim <namhyung@gmail.com>
Cc: x86 <x86@kernel.org>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Robert Richter <robert.richter@amd.com>
Cc: Paul Mundt <lethal@linux-sh.org>
Link: http://lkml.kernel.org/r/1305205872-10321-2-git-send-email-richard@nod.at


Signed-off-by: default avatarFrederic Weisbecker <fweisbec@gmail.com>
parent 2b348a77

arch/x86/include/asm/stacktrace.h

+0 −3
Original line number Diff line number Diff line
@@ -37,9 +37,6 @@ print_context_stack_bp(struct thread_info *tinfo, 
/* Generic stack tracer with callbacks */



struct stacktrace_ops {

	void (*warning)(void *data, char *msg);

	/* msg must contain %s for the symbol */

	void (*warning_symbol)(void *data, char *msg, unsigned long symbol);

	void (*address)(void *data, unsigned long address, int reliable);

	/* On negative return stop dumping */

	int (*stack)(void *data, char *name);

arch/x86/kernel/cpu/perf_event.c

+0 −13
Original line number Diff line number Diff line
@@ -1773,17 +1773,6 @@ static struct pmu pmu = { 
 * callchain support

 */



static void

backtrace_warning_symbol(void *data, char *msg, unsigned long symbol)

{

	/* Ignore warnings */

}



static void backtrace_warning(void *data, char *msg)

{

	/* Ignore warnings */

}



static int backtrace_stack(void *data, char *name)

{

	return 0;
@@ -1797,8 +1786,6 @@ static void backtrace_address(void *data, unsigned long addr, int reliable) 
}



static const struct stacktrace_ops backtrace_ops = {

	.warning		= backtrace_warning,

	.warning_symbol		= backtrace_warning_symbol,

	.stack			= backtrace_stack,

	.address		= backtrace_address,

	.walk_stack		= print_context_stack_bp,

arch/x86/kernel/dumpstack.c

+0 −16
Original line number Diff line number Diff line
@@ -135,20 +135,6 @@ print_context_stack_bp(struct thread_info *tinfo, 
}

EXPORT_SYMBOL_GPL(print_context_stack_bp);





static void

print_trace_warning_symbol(void *data, char *msg, unsigned long symbol)

{

	printk(data);

	print_symbol(msg, symbol);

	printk("\n");

}



static void print_trace_warning(void *data, char *msg)

{

	printk("%s%s\n", (char *)data, msg);

}



static int print_trace_stack(void *data, char *name)

{

	printk("%s <%s> ", (char *)data, name);
@@ -166,8 +152,6 @@ static void print_trace_address(void *data, unsigned long addr, int reliable) 
}



static const struct stacktrace_ops print_trace_ops = {

	.warning		= print_trace_warning,

	.warning_symbol		= print_trace_warning_symbol,

	.stack			= print_trace_stack,

	.address		= print_trace_address,

	.walk_stack		= print_context_stack,

arch/x86/kernel/stacktrace.c

+0 −13
Original line number Diff line number Diff line
@@ -9,15 +9,6 @@ 
#include <linux/uaccess.h>

#include <asm/stacktrace.h>



static void save_stack_warning(void *data, char *msg)

{

}



static void

save_stack_warning_symbol(void *data, char *msg, unsigned long symbol)

{

}



static int save_stack_stack(void *data, char *name)

{

	return 0;
@@ -53,16 +44,12 @@ save_stack_address_nosched(void *data, unsigned long addr, int reliable) 
}



static const struct stacktrace_ops save_stack_ops = {

	.warning	= save_stack_warning,

	.warning_symbol	= save_stack_warning_symbol,

	.stack		= save_stack_stack,

	.address	= save_stack_address,

	.walk_stack	= print_context_stack,

};



static const struct stacktrace_ops save_stack_ops_nosched = {

	.warning	= save_stack_warning,

	.warning_symbol	= save_stack_warning_symbol,

	.stack		= save_stack_stack,

	.address	= save_stack_address_nosched,

	.walk_stack	= print_context_stack,

arch/x86/oprofile/backtrace.c

+0 −13
Original line number Diff line number Diff line
@@ -16,17 +16,6 @@ 
#include <asm/stacktrace.h>

#include <linux/compat.h>



static void backtrace_warning_symbol(void *data, char *msg,

				     unsigned long symbol)

{

	/* Ignore warnings */

}



static void backtrace_warning(void *data, char *msg)

{

	/* Ignore warnings */

}



static int backtrace_stack(void *data, char *name)

{

	/* Yes, we want all stacks */
@@ -42,8 +31,6 @@ static void backtrace_address(void *data, unsigned long addr, int reliable) 
}



static struct stacktrace_ops backtrace_ops = {

	.warning	= backtrace_warning,

	.warning_symbol	= backtrace_warning_symbol,

	.stack		= backtrace_stack,

	.address	= backtrace_address,

	.walk_stack	= print_context_stack,

CRA Git | Maintained and supported by SUSTech CRA and CCSE