Commit 449867e3 authored Nov 26, 2013 by Adrian Hunter Committed by Arnaldo Carvalho de Melo Nov 27, 2013

perf symbols: Fix not finding kcore in buildid cache



The logic was not looking in the buildid cache for kcore if the host
kernel buildid did not match the recorded kernel buildid.

This affects the non-live case i.e. the kernel has changed and we are
looking at a special copy of kcore that we placed in the buildid cache
(using "perf buildid-cache -v -k /proc/kcore") when the data was
recorded.

After this fix kernel symbols get resolved/annotated correctly.

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Namhyung Kim <namhyung@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/1385471964-4037-1-git-send-email-adrian.hunter@intel.com


[ Added further explanation extracted from conversation between Ingo & Adrian on lkml ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent ba1ddf42

tools/perf/util/symbol.c

+7 −2

Original line number	Diff line number	Diff line
		@@ -1526,14 +1526,15 @@ static char dso__find_kallsyms(struct dso dso, struct map *map)

		build_id__sprintf(dso->build_id, sizeof(dso->build_id), sbuild_id);

		scnprintf(path, sizeof(path), "%s/[kernel.kcore]/%s", buildid_dir,
		sbuild_id);

		/* Use /proc/kallsyms if possible */
		if (is_host) {
		DIR *d;
		int fd;

		/* If no cached kcore go with /proc/kallsyms */
		scnprintf(path, sizeof(path), "%s/[kernel.kcore]/%s",
		buildid_dir, sbuild_id);
		d = opendir(path);
		if (!d)
		goto proc_kallsyms;
		@@ -1558,6 +1559,10 @@ static char dso__find_kallsyms(struct dso dso, struct map *map)
		goto proc_kallsyms;
		}

		/* Find kallsyms in build-id cache with kcore */
		if (!find_matching_kcore(map, path, sizeof(path)))
		return strdup(path);

		scnprintf(path, sizeof(path), "%s/[kernel.kallsyms]/%s",
		buildid_dir, sbuild_id);

Admin message