Commit 448f13b2 authored Dec 11, 2015 by Namhyung Kim Committed by Arnaldo Carvalho de Melo Dec 11, 2015

perf top: Fix annotation on --stdio



The ui__has_annotation() inside perf_top__record_precise_ip() should be
removed since it returns true only for TUI (and when sort key has
symbol).  However the 'perf top --stdio' also supports annotation for a
symbol which was specified by 's' key action.

Actually it already does the necessary checks before calling the
function.  So it's ok to get rid of the check here.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1449802616-16170-3-git-send-email-namhyung@kernel.org


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent 151ee834

tools/perf/builtin-top.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -189,7 +189,6 @@ static void perf_top__record_precise_ip(struct perf_top *top,
		if (pthread_mutex_trylock(&notes->lock))
		return;

		if (ui__has_annotation())
		err = hist_entry__inc_addr_samples(he, counter, ip);

		pthread_mutex_unlock(&notes->lock);

Admin message