remoteproc: Add remoteproc character device interface (44767708) · Commits · 戴 / test

Documentation/userspace-api/ioctl/ioctl-number.rst

+1 −0

Original line number	Diff line number	Diff line
		@@ -339,6 +339,7 @@ Code Seq# Include File Comments
		0xB4 00-0F linux/gpio.h <mailto:linux-gpio@vger.kernel.org>
		0xB5 00-0F uapi/linux/rpmsg.h <mailto:linux-remoteproc@vger.kernel.org>
		0xB6 all linux/fpga-dfl.h
		0xB7 all uapi/linux/remoteproc_cdev.h <mailto:linux-remoteproc@vger.kernel.org>
		0xC0 00-0F linux/usb/iowarrior.h
		0xCA 00-0F uapi/misc/cxl.h
		0xCA 10-2F uapi/misc/ocxl.h

drivers/remoteproc/Kconfig

+9 −0

Original line number	Diff line number	Diff line
		@@ -14,6 +14,15 @@ config REMOTEPROC

		if REMOTEPROC

		config REMOTEPROC_CDEV
		bool "Remoteproc character device interface"
		help
		Say y here to have a character device interface for the remoteproc
		framework. Userspace can boot/shutdown remote processors through
		this interface.

		It's safe to say N if you don't want to use this interface.

		config IMX_REMOTEPROC
		tristate "IMX6/7 remoteproc support"
		depends on ARCH_MXC

drivers/remoteproc/Makefile

+1 −0

Original line number	Diff line number	Diff line
		@@ -10,6 +10,7 @@ remoteproc-y += remoteproc_debugfs.o
		remoteproc-y += remoteproc_sysfs.o
		remoteproc-y += remoteproc_virtio.o
		remoteproc-y += remoteproc_elf_loader.o
		obj-$(CONFIG_REMOTEPROC_CDEV) += remoteproc_cdev.o
		obj-$(CONFIG_IMX_REMOTEPROC) += imx_rproc.o
		obj-$(CONFIG_INGENIC_VPU_RPROC) += ingenic_rproc.o
		obj-$(CONFIG_MTK_SCP) += mtk_scp.o mtk_scp_ipi.o

drivers/remoteproc/remoteproc_cdev.c

0 → 100644

+124 −0

Original line number	Diff line number	Diff line
		// SPDX-License-Identifier: GPL-2.0-only
		/*
		* Character device interface driver for Remoteproc framework.
		*
		* Copyright (c) 2020, The Linux Foundation. All rights reserved.
		*/

		#include <linux/cdev.h>
		#include <linux/compat.h>
		#include <linux/fs.h>
		#include <linux/module.h>
		#include <linux/remoteproc.h>
		#include <linux/uaccess.h>
		#include <uapi/linux/remoteproc_cdev.h>

		#include "remoteproc_internal.h"

		#define NUM_RPROC_DEVICES 64
		static dev_t rproc_major;

		static ssize_t rproc_cdev_write(struct file filp, const char __user buf, size_t len, loff_t *pos)
		{
		struct rproc *rproc = container_of(filp->f_inode->i_cdev, struct rproc, cdev);
		int ret = 0;
		char cmd[10];

		if (!len \|\| len > sizeof(cmd))
		return -EINVAL;

		ret = copy_from_user(cmd, buf, len);
		if (ret)
		return -EFAULT;

		if (!strncmp(cmd, "start", len)) {
		if (rproc->state == RPROC_RUNNING)
		return -EBUSY;

		ret = rproc_boot(rproc);
		} else if (!strncmp(cmd, "stop", len)) {
		if (rproc->state != RPROC_RUNNING)
		return -EINVAL;

		rproc_shutdown(rproc);
		} else {
		dev_err(&rproc->dev, "Unrecognized option\n");
		ret = -EINVAL;
		}

		return ret ? ret : len;
		}

		static long rproc_device_ioctl(struct file *filp, unsigned int ioctl, unsigned long arg)
		{
		struct rproc *rproc = container_of(filp->f_inode->i_cdev, struct rproc, cdev);
		void __user argp = (void __user )arg;
		s32 param;

		switch (ioctl) {
		case RPROC_SET_SHUTDOWN_ON_RELEASE:
		if (copy_from_user(&param, argp, sizeof(s32)))
		return -EFAULT;

		rproc->cdev_put_on_release = !!param;
		break;
		case RPROC_GET_SHUTDOWN_ON_RELEASE:
		param = (s32)rproc->cdev_put_on_release;
		if (copy_to_user(argp, &param, sizeof(s32)))
		return -EFAULT;

		break;
		default:
		dev_err(&rproc->dev, "Unsupported ioctl\n");
		return -EINVAL;
		}

		return 0;
		}

		static int rproc_cdev_release(struct inode inode, struct file filp)
		{
		struct rproc *rproc = container_of(inode->i_cdev, struct rproc, cdev);

		if (rproc->cdev_put_on_release && rproc->state == RPROC_RUNNING)
		rproc_shutdown(rproc);

		return 0;
		}

		static const struct file_operations rproc_fops = {
		.write = rproc_cdev_write,
		.unlocked_ioctl = rproc_device_ioctl,
		.compat_ioctl = compat_ptr_ioctl,
		.release = rproc_cdev_release,
		};

		int rproc_char_device_add(struct rproc *rproc)
		{
		int ret;

		cdev_init(&rproc->cdev, &rproc_fops);
		rproc->cdev.owner = THIS_MODULE;

		rproc->dev.devt = MKDEV(MAJOR(rproc_major), rproc->index);
		cdev_set_parent(&rproc->cdev, &rproc->dev.kobj);
		ret = cdev_add(&rproc->cdev, rproc->dev.devt, 1);
		if (ret < 0)
		dev_err(&rproc->dev, "Failed to add char dev for %s\n", rproc->name);

		return ret;
		}

		void rproc_char_device_remove(struct rproc *rproc)
		{
		__unregister_chrdev(MAJOR(rproc->dev.devt), rproc->index, 1, "remoteproc");
		}

		void __init rproc_init_cdev(void)
		{
		int ret;

		ret = alloc_chrdev_region(&rproc_major, 0, NUM_RPROC_DEVICES, "remoteproc");
		if (ret < 0)
		pr_err("Failed to alloc rproc_cdev region, err %d\n", ret);
		}

drivers/remoteproc/remoteproc_internal.h

+28 −0

Original line number	Diff line number	Diff line
		@@ -53,6 +53,34 @@ void rproc_exit_sysfs(void);
		void rproc_coredump_cleanup(struct rproc *rproc);
		void rproc_coredump(struct rproc *rproc);

		#ifdef CONFIG_REMOTEPROC_CDEV
		void rproc_init_cdev(void);
		void rproc_exit_cdev(void);
		int rproc_char_device_add(struct rproc *rproc);
		void rproc_char_device_remove(struct rproc *rproc);
		#else
		static inline void rproc_init_cdev(void)
		{
		}

		static inline void rproc_exit_cdev(void)
		{
		}

		/*
		* The character device interface is an optional feature, if it is not enabled
		* the function should not return an error.
		*/
		static inline int rproc_char_device_add(struct rproc *rproc)
		{
		return 0;
		}

		static inline void rproc_char_device_remove(struct rproc *rproc)
		{
		}
		#endif

		void rproc_free_vring(struct rproc_vring *rvring);
		int rproc_alloc_vring(struct rproc_vdev *rvdev, int i);

Admin message