Commit 4474ca42 authored Mar 19, 2012 by NeilBrown

md/bitmap: ensure to load bitmap when creating via sysfs.



When commit 69e51b44 (md/bitmap:  separate out loading a bitmap...)
created bitmap_load, it missed calling it after bitmap_create when a
bitmap is created through the sysfs interface.
So if a bitmap is added this way, we don't allocate memory properly
and can crash.

This is suitable for any -stable release since 2.6.35.
Cc: stable@vger.kernel.org
Signed-off-by: NeilBrown <neilb@suse.de>

parent c744a65c

drivers/md/bitmap.c

+2 −0

Original line number	Original line	Diff line number	Diff line
	@@ -1904,6 +1904,8 @@ location_store(struct mddev mddev, const char buf, size_t len)
	if (mddev->pers) {		if (mddev->pers) {
	mddev->pers->quiesce(mddev, 1);		mddev->pers->quiesce(mddev, 1);
	rv = bitmap_create(mddev);		rv = bitmap_create(mddev);
			if (!rv)
			rv = bitmap_load(mddev);
	if (rv) {		if (rv) {
	bitmap_destroy(mddev);		bitmap_destroy(mddev);
	mddev->bitmap_info.offset = 0;		mddev->bitmap_info.offset = 0;

Admin message