Commit 447458c0 authored Jul 10, 2012 by Dan Carpenter Committed by David S. Miller Jul 16, 2012

net/mlx4: off by one in parse_trans_rule()



This should be ">=" here instead of ">".  MLX4_NET_TRANS_RULE_NUM is 6.
We use "spec->id" as an array offset into the __rule_hw_sz[] and
__sw_id_hw[] arrays which have 6 elements.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Hadar Hen Zion <hadarh@mellanox.co.il>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent f0396f60

drivers/net/ethernet/mellanox/mlx4/mcg.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -773,7 +773,7 @@ static int parse_trans_rule(struct mlx4_dev dev, struct mlx4_spec_list spec,
		[MLX4_NET_TRANS_RULE_ID_UDP] =
		sizeof(struct mlx4_net_trans_rule_hw_tcp_udp)
		};
		if (spec->id > MLX4_NET_TRANS_RULE_NUM) {
		if (spec->id >= MLX4_NET_TRANS_RULE_NUM) {
		mlx4_err(dev, "Invalid network rule id. id = %d\n", spec->id);
		return -EINVAL;
		}

Admin message