Commit 44481955 authored Mar 07, 2019 by Nathan Chancellor Committed by Thierry Reding Mar 20, 2019

pwm: img: Turn final 'else if' into 'else' in img_pwm_config

When building with -Wsometimes-uninitialized, Clang warns:

drivers/pwm/pwm-img.c:126:13: error: variable 'timebase' is used
uninitialized whenever 'if' condition is false
[-Werror,-Wsometimes-uninitialized]

The final else if functions as an else; make that explicit so that Clang
understands that timebase cannot be used uninitialized.

Link: https://github.com/ClangBuiltLinux/linux/issues/400


Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>

parent 347ab948

drivers/pwm/pwm-img.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -123,7 +123,7 @@ static int img_pwm_config(struct pwm_chip chip, struct pwm_device pwm,
		} else if (mul <= max_timebase * 512) {
		div = PWM_CTRL_CFG_SUB_DIV0_DIV1;
		timebase = DIV_ROUND_UP(mul, 512);
		} else if (mul > max_timebase * 512) {
		} else {
		dev_err(chip->dev,
		"failed to configure timebase steps/divider value\n");
		return -EINVAL;

Admin message