Commit 4441eb02 authored Sep 02, 2020 by Ravi Bangoria Committed by Michael Ellerman Sep 15, 2020

powerpc/watchpoint: Fix handling of vector instructions

Vector load/store instructions are special because they are always
aligned. Thus unaligned EA needs to be aligned down before comparing
it with watch ranges. Otherwise we might consider valid event as
invalid.

Fixes: 74c68810 ("powerpc/watchpoint: Prepare handler to handle more than one watchpoint")
Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20200902042945.129369-3-ravi.bangoria@linux.ibm.com

parent 4759c11e

arch/powerpc/kernel/hw_breakpoint.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -644,6 +644,8 @@ static void get_instr_detail(struct pt_regs regs, struct ppc_inst instr,
		if (*type == CACHEOP) {
		*size = cache_op_size();
		ea &= ~(size - 1);
		} else if (type == LOAD_VMX \|\| type == STORE_VMX) {
		ea &= ~(size - 1);
		}
		}