Commit 443c39bc authored Jan 22, 2010 by Wei Yongjun Committed by Marcelo Tosatti Jan 25, 2010

KVM: x86: Fix leak of free lapic date in kvm_arch_vcpu_init()



In function kvm_arch_vcpu_init(), if the memory malloc for
vcpu->arch.mce_banks is fail, it does not free the memory
of lapic date. This patch fixed it.

Cc: stable@kernel.org
Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>

parent 36cb93fd

arch/x86/kvm/x86.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -5072,12 +5072,13 @@ int kvm_arch_vcpu_init(struct kvm_vcpu *vcpu)
		GFP_KERNEL);
		if (!vcpu->arch.mce_banks) {
		r = -ENOMEM;
		goto fail_mmu_destroy;
		goto fail_free_lapic;
		}
		vcpu->arch.mcg_cap = KVM_MAX_MCE_BANKS;

		return 0;

		fail_free_lapic:
		kvm_free_lapic(vcpu);
		fail_mmu_destroy:
		kvm_mmu_destroy(vcpu);
		fail_free_pio_data:

Admin message