Commit 4414b3ed authored Mar 16, 2018 by Grygorii Strashko Committed by David S. Miller Mar 19, 2018

net: phy: relax error checking when creating sysfs link netdev->phydev

Some ethernet drivers (like TI CPSW) may connect and manage >1 Net PHYs per
one netdevice, as result such drivers will produce warning during system
boot and fail to connect second phy to netdevice when PHYLIB framework
will try to create sysfs link netdev->phydev for second PHY
in phy_attach_direct(), because sysfs link with the same name has been
created already for the first PHY. As result, second CPSW external
port will became unusable.

Fix it by relaxing error checking when PHYLIB framework is creating sysfs
link netdev->phydev in phy_attach_direct(), suppressing warning by using
sysfs_create_link_nowarn() and adding error message instead.
After this change links (phy->netdev and netdev->phy) creation failure is not
fatal any more and system can continue working, which fixes TI CPSW issue.

Cc: Florian Fainelli <f.fainelli@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>
Fixes: a3995460 ("net: phy: Relax error checking on sysfs_create_link()")
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 2399ac42

drivers/net/phy/phy_device.c

+11 −4

Original line number	Diff line number	Diff line
		@@ -1012,10 +1012,17 @@ int phy_attach_direct(struct net_device dev, struct phy_device phydev,
		err = sysfs_create_link(&phydev->mdio.dev.kobj, &dev->dev.kobj,
		"attached_dev");
		if (!err) {
		err = sysfs_create_link(&dev->dev.kobj, &phydev->mdio.dev.kobj,
		err = sysfs_create_link_nowarn(&dev->dev.kobj,
		&phydev->mdio.dev.kobj,
		"phydev");
		if (err)
		goto error;
		if (err) {
		dev_err(&dev->dev, "could not add device link to %s err %d\n",
		kobject_name(&phydev->mdio.dev.kobj),
		err);
		/* non-fatal - some net drivers can use one netdevice
		* with more then one phy
		*/
		}

		phydev->sysfs_links = true;
		}

Admin message