Commit 440b6d50 authored Jan 08, 2020 by Vignesh Raghavendra Committed by Miquel Raynal Jan 17, 2020

mtd: spi-nor: Fix selection of 4-byte addressing opcodes on Spansion



mtd->size is still unassigned when running spansion_post_sfdp_fixups()
hook, therefore use nor->params.size to determine the size of flash device.

This makes sure that 4-byte addressing opcodes are used on Spansion
flashes that are larger than 16MiB and don't have SFDP 4BAIT table
populated.

Fixes: 92094ebc ("mtd: spi-nor: Add spansion_post_sfdp_fixups()")
Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>

parent b3a987b0

drivers/mtd/spi-nor/spi-nor.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -4769,9 +4769,7 @@ static void spi_nor_info_init_params(struct spi_nor *nor)

		static void spansion_post_sfdp_fixups(struct spi_nor *nor)
		{
		struct mtd_info *mtd = &nor->mtd;

		if (mtd->size <= SZ_16M)
		if (nor->params.size <= SZ_16M)
		return;

		nor->flags \|= SNOR_F_4B_OPCODES;

Admin message