Commit 43fc99f2 authored Apr 13, 2017 by Mark Brown

regulator: core: Only propagate voltage changes to if it can change voltages



When we are propagating voltage changes to parent regulators don't
bother if the parent does not have permission to change voltages.  This
simplifies error checking in the function for cases where the regulator
lacks some of the voltage operations.

Reported-by: Dong Aisheng <aisheng.dong@nxp.com>
Tested-by: Dong Aisheng <aisheng.dong@nxp.com>
Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent fd086045

drivers/regulator/core.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -2939,8 +2939,10 @@ static int regulator_set_voltage_unlocked(struct regulator *regulator,
		if (ret < 0)
		goto out2;

		if (rdev->supply && (rdev->desc->min_dropout_uV \|\|
		!rdev->desc->ops->get_voltage)) {
		if (rdev->supply &&
		regulator_ops_is_valid(rdev->supply->rdev,
		REGULATOR_CHANGE_VOLTAGE) &&
		(rdev->desc->min_dropout_uV \|\| !rdev->desc->ops->get_voltage)) {
		int current_supply_uV;
		int selector;

Admin message