Commit 43f78531 authored Jun 10, 2009 by Luis R. Rodriguez Committed by John W. Linville Jun 10, 2009

mac80211: disable moving between PS modes during scan

We don't want to trigger moving between PS mode during scan,
because then we will sometimes end up sending nullfunc frames
during scan. We're supposed to only send one prior to scan
and after scan.

This fixes an oops which occured due to an assert in ath9k:

http://marc.info/?l=linux-wireless&m=124277331319024



The assert was happening because the rate control algorithm
figures it should find at least one valid dual stream or
single stream rate. Since we allow mac80211 to send nullfunc
frames during scan and dynamic PS was enabled at times we ended
up trying to send nullfunc frames for the target sta on the
wrong band for which we have no valid rate to communicate with
it. This breaks the assumptions in rate control.

We determine we also need to disable moving between PS modes
when not associated so lets just add that now as well, and we
should not have a ps_sdata when that interface cannot actually
go into PS because it's not associated.

Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

parent a6ae0716

net/mac80211/mlme.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -621,9 +621,6 @@ static void ieee80211_change_ps(struct ieee80211_local *local)
		struct ieee80211_conf *conf = &local->hw.conf;

		if (local->ps_sdata) {
		if (!(local->ps_sdata->u.mgd.flags & IEEE80211_STA_ASSOCIATED))
		return;

		ieee80211_enable_ps(local, local->ps_sdata);
		} else if (conf->flags & IEEE80211_CONF_PS) {
		conf->flags &= ~IEEE80211_CONF_PS;
		@@ -653,7 +650,8 @@ void ieee80211_recalc_ps(struct ieee80211_local *local, s32 latency)
		count++;
		}

		if (count == 1 && found->u.mgd.powersave) {
		if (count == 1 && found->u.mgd.powersave &&
		(found->u.mgd.flags & IEEE80211_STA_ASSOCIATED)) {
		s32 beaconint_us;

		if (latency < 0)

net/mac80211/tx.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -1415,7 +1415,8 @@ int ieee80211_master_start_xmit(struct sk_buff skb, struct net_device dev)
		}

		if ((local->hw.flags & IEEE80211_HW_PS_NULLFUNC_STACK) &&
		local->hw.conf.dynamic_ps_timeout > 0) {
		local->hw.conf.dynamic_ps_timeout > 0 &&
		!local->sw_scanning && !local->hw_scanning && local->ps_sdata) {
		if (local->hw.conf.flags & IEEE80211_CONF_PS) {
		ieee80211_stop_queues_by_reason(&local->hw,
		IEEE80211_QUEUE_STOP_REASON_PS);

Admin message