Commit 43effa1e authored by Patrick McHardy's avatar Patrick McHardy Committed by David S. Miller
Browse files

[NET_SCHED]: Fix endless loops caused by inaccurate qlen counters (part 1) 



There are multiple problems related to qlen adjustment that can lead
to an upper qdisc getting out of sync with the real number of packets
queued, leading to endless dequeueing attempts by the upper layer code.

All qdiscs must maintain an accurate q.qlen counter. There are basically
two groups of operations affecting the qlen: operations that propagate
down the tree (enqueue, dequeue, requeue, drop, reset) beginning at the
root qdisc and operations only affecting a subtree or single qdisc
(change, graft, delete class). Since qlen changes during operations from
the second group don't propagate to ancestor qdiscs, their qlen values
become desynchronized.

This patch adds a function to propagate qlen changes up the qdisc tree,
optionally calling a callback function to perform qdisc-internal
maintenance when the child qdisc becomes empty. The follow-up patches
will convert all qdiscs to use this function where necessary.

Noticed by Timo Steinbach <tsteinbach@astaro.com>.

Signed-off-by: default avatarPatrick McHardy <kaber@trash.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 9f9afec4

include/net/sch_generic.h

+2 −0
Original line number Diff line number Diff line
@@ -60,6 +60,7 @@ struct Qdisc_class_ops 
	int			(*graft)(struct Qdisc *, unsigned long cl,

					struct Qdisc *, struct Qdisc **);

	struct Qdisc *		(*leaf)(struct Qdisc *, unsigned long cl);

	void			(*qlen_notify)(struct Qdisc *, unsigned long);



	/* Class manipulation routines */

	unsigned long		(*get)(struct Qdisc *, u32 classid);
@@ -172,6 +173,7 @@ extern void dev_activate(struct net_device *dev); 
extern void dev_deactivate(struct net_device *dev);

extern void qdisc_reset(struct Qdisc *qdisc);

extern void qdisc_destroy(struct Qdisc *qdisc);

extern void qdisc_tree_decrease_qlen(struct Qdisc *qdisc, unsigned int n);

extern struct Qdisc *qdisc_alloc(struct net_device *dev, struct Qdisc_ops *ops);

extern struct Qdisc *qdisc_create_dflt(struct net_device *dev,

				       struct Qdisc_ops *ops, u32 parentid);

net/sched/sch_api.c

+32 −6
Original line number Diff line number Diff line
@@ -191,19 +191,25 @@ int unregister_qdisc(struct Qdisc_ops *qops) 
   (root qdisc, all its children, children of children etc.)

 */



struct Qdisc *qdisc_lookup(struct net_device *dev, u32 handle)

static struct Qdisc *__qdisc_lookup(struct net_device *dev, u32 handle)

{

	struct Qdisc *q;



	read_lock(&qdisc_tree_lock);

	list_for_each_entry(q, &dev->qdisc_list, list) {

		if (q->handle == handle) {

			read_unlock(&qdisc_tree_lock);

		if (q->handle == handle)

			return q;

	}

	return NULL;

}



struct Qdisc *qdisc_lookup(struct net_device *dev, u32 handle)

{

	struct Qdisc *q;



	read_lock(&qdisc_tree_lock);

	q = __qdisc_lookup(dev, handle);

	read_unlock(&qdisc_tree_lock);

	return NULL;

	return q;

}



static struct Qdisc *qdisc_leaf(struct Qdisc *p, u32 classid)
@@ -348,6 +354,26 @@ dev_graft_qdisc(struct net_device *dev, struct Qdisc *qdisc) 
	return oqdisc;

}



void qdisc_tree_decrease_qlen(struct Qdisc *sch, unsigned int n)

{

	struct Qdisc_class_ops *cops;

	unsigned long cl;

	u32 parentid;



	if (n == 0)

		return;

	while ((parentid = sch->parent)) {

		sch = __qdisc_lookup(sch->dev, TC_H_MAJ(parentid));

		cops = sch->ops->cl_ops;

		if (cops->qlen_notify) {

			cl = cops->get(sch, parentid);

			cops->qlen_notify(sch, cl);

			cops->put(sch, cl);

		}

		sch->q.qlen -= n;

	}

}

EXPORT_SYMBOL(qdisc_tree_decrease_qlen);



/* Graft qdisc "new" to class "classid" of qdisc "parent" or

   to device "dev".

CRA Git | Maintained and supported by SUSTech CRA and CCSE