Commit 43eab861 authored by Archit Taneja's avatar Archit Taneja
Browse files

OMAPDSS: RFBI: Remove partial update support 



Partial update suppport was removed from DISPC and DSI sometime back. The RFBI
driver still tries to support partial update without the underlying support in
DISPC.

Remove partial update support from RFBI, only support updates which span acros
the whole panel size. This also helps in DSI and RFBI having similar update
ops.

Signed-off-by: default avatarArchit Taneja <archit@ti.com>
parent a5abf472

drivers/video/omap2/displays/panel-n8x0.c

+11 −3
Original line number Diff line number Diff line
@@ -625,17 +625,25 @@ static int n8x0_panel_update(struct omap_dss_device *dssdev, 
		u16 x, u16 y, u16 w, u16 h)

{

	struct panel_drv_data *ddata = get_drv_data(dssdev);

	u16 dw, dh;



	dev_dbg(&dssdev->dev, "update\n");



	dw = dssdev->panel.timings.x_res;

	dh = dssdev->panel.timings.y_res;



	if (x != 0 || y != 0 || w != dw || h != dh) {

		dev_err(&dssdev->dev, "invaid update region %d, %d, %d, %d\n",

			x, y, w, h);

		return -EINVAL;

	}



	mutex_lock(&ddata->lock);

	rfbi_bus_lock();



	omap_rfbi_prepare_update(dssdev, &x, &y, &w, &h);



	blizzard_ctrl_setup_update(dssdev, x, y, w, h);



	omap_rfbi_update(dssdev, x, y, w, h, update_done, NULL);

	omap_rfbi_update(dssdev, update_done, NULL);



	mutex_unlock(&ddata->lock);

drivers/video/omap2/dss/rfbi.c

+18 −58
Original line number Diff line number Diff line
@@ -300,21 +300,24 @@ void omap_rfbi_write_pixels(const void __iomem *buf, int scr_width, 
}

EXPORT_SYMBOL(omap_rfbi_write_pixels);



static int rfbi_transfer_area(struct omap_dss_device *dssdev, u16 width,

		u16 height, void (*callback)(void *data), void *data)

static int rfbi_transfer_area(struct omap_dss_device *dssdev,

		void (*callback)(void *data), void *data)

{

	u32 l;

	int r;

	struct omap_video_timings timings = {

		.hsw		= 1,

		.hfp		= 1,

		.hbp		= 1,

		.vsw		= 1,

		.vfp		= 0,

		.vbp		= 0,

		.x_res		= width,

		.y_res		= height,

	};

	struct omap_video_timings timings;

	u16 width, height;



	dssdev->driver->get_resolution(dssdev, &width, &height);



	timings.x_res = width;

	timings.y_res = height;

	timings.hsw = 1;

	timings.hfp = 1;

	timings.hbp = 1;

	timings.vsw = 1;

	timings.vfp = 0;

	timings.vbp = 0;



	/*BUG_ON(callback == 0);*/

	BUG_ON(rfbi.framedone_callback != NULL);
@@ -777,53 +780,10 @@ int omap_rfbi_configure(struct omap_dss_device *dssdev, int pixel_size, 
}

EXPORT_SYMBOL(omap_rfbi_configure);



int omap_rfbi_prepare_update(struct omap_dss_device *dssdev,

		u16 *x, u16 *y, u16 *w, u16 *h)

{

	u16 dw, dh;

	struct omap_video_timings timings = {

		.hsw		= 1,

		.hfp		= 1,

		.hbp		= 1,

		.vsw		= 1,

		.vfp		= 0,

		.vbp		= 0,

		.x_res		= *w,

		.y_res		= *h,

	};



	dssdev->driver->get_resolution(dssdev, &dw, &dh);



	if  (*x > dw || *y > dh)

		return -EINVAL;



	if (*x + *w > dw)

		return -EINVAL;



	if (*y + *h > dh)

		return -EINVAL;



	if (*w == 1)

		return -EINVAL;



	if (*w == 0 || *h == 0)

		return -EINVAL;



	dss_mgr_set_timings(dssdev->manager, &timings);



	return 0;

}

EXPORT_SYMBOL(omap_rfbi_prepare_update);



int omap_rfbi_update(struct omap_dss_device *dssdev,

		u16 x, u16 y, u16 w, u16 h,

		void (*callback)(void *), void *data)

int omap_rfbi_update(struct omap_dss_device *dssdev, void (*callback)(void *),

		void *data)

{

	int r;



	r = rfbi_transfer_area(dssdev, w, h, callback, data);



	return r;

	return rfbi_transfer_area(dssdev, callback, data);

}

EXPORT_SYMBOL(omap_rfbi_update);

include/video/omapdss.h

+2 −5
Original line number Diff line number Diff line
@@ -749,11 +749,8 @@ void omapdss_sdi_set_timings(struct omap_dss_device *dssdev, 


int omapdss_rfbi_display_enable(struct omap_dss_device *dssdev);

void omapdss_rfbi_display_disable(struct omap_dss_device *dssdev);

int omap_rfbi_prepare_update(struct omap_dss_device *dssdev,

		u16 *x, u16 *y, u16 *w, u16 *h);

int omap_rfbi_update(struct omap_dss_device *dssdev,

		u16 x, u16 y, u16 w, u16 h,

		void (*callback)(void *), void *data);

int omap_rfbi_update(struct omap_dss_device *dssdev, void (*callback)(void *),

		void *data);

int omap_rfbi_configure(struct omap_dss_device *dssdev, int pixel_size,

		int data_lines);

CRA Git | Maintained and supported by SUSTech CRA and CCSE