Commit 43dc0aa8 authored May 08, 2020 by Brian Foster Committed by Darrick J. Wong May 08, 2020

xfs: fix unused variable warning in buffer completion on !DEBUG



The random buffer write failure errortag patch introduced a local
mount pointer variable for the test macro, but the macro is compiled
out on !DEBUG kernels. This results in an unused variable warning.

Access the mount structure through the buffer pointer and remove the
local mount pointer to address the warning.

Fixes: 7376d745 ("xfs: random buffer write failure errortag")
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

parent 6ea670ad

fs/xfs/xfs_buf.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -1289,11 +1289,10 @@ xfs_buf_bio_end_io(
		struct bio *bio)
		{
		struct xfs_buf bp = (struct xfs_buf )bio->bi_private;
		struct xfs_mount *mp = bp->b_mount;

		if (!bio->bi_status &&
		(bp->b_flags & XBF_WRITE) && (bp->b_flags & XBF_ASYNC) &&
		XFS_TEST_ERROR(false, mp, XFS_ERRTAG_BUF_IOERROR))
		XFS_TEST_ERROR(false, bp->b_mount, XFS_ERRTAG_BUF_IOERROR))
		bio->bi_status = BLK_STS_IOERR;

		/*

Admin message