usb: gadget: ffs: ffs_aio_cancel(): Save/restore IRQ flags (43d56572) · Commits · 戴 / test

ffs_aio_cancel() can be called from both interrupt and thread context. Make sure that the current IRQ state is saved and restored by using spin_{un,}lock_irq{save,restore}(). Otherwise undefined behavior might occur. Acked-by:

Michal Nazarewicz <mina86@mina86.com> Signed-off-by:

Lars-Peter Clausen <lars@metafoo.de> Signed-off-by:

Alexandru Ardelean <alexandru.ardelean@analog.com> Signed-off-by:

Felipe Balbi <balbi@kernel.org>

drivers/usb/gadget/function/f_fs.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -1162,18 +1162,19 @@ static int ffs_aio_cancel(struct kiocb *kiocb)
		{
		struct ffs_io_data *io_data = kiocb->private;
		struct ffs_epfile *epfile = kiocb->ki_filp->private_data;
		unsigned long flags;
		int value;

		ENTER();

		spin_lock_irq(&epfile->ffs->eps_lock);
		spin_lock_irqsave(&epfile->ffs->eps_lock, flags);

		if (likely(io_data && io_data->ep && io_data->req))
		value = usb_ep_dequeue(io_data->ep, io_data->req);
		else
		value = -EINVAL;

		spin_unlock_irq(&epfile->ffs->eps_lock);
		spin_unlock_irqrestore(&epfile->ffs->eps_lock, flags);

		return value;
		}

Admin message