drm/bridge: megachips: add helper to create connector (43c601a6) · Commits · 戴 / test

drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c

+27 −20

Original line number	Diff line number	Diff line
		@@ -191,6 +191,32 @@ static const struct drm_connector_funcs ge_b850v3_lvds_connector_funcs = {
		.atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
		};

		static int ge_b850v3_lvds_create_connector(struct drm_bridge *bridge)
		{
		struct drm_connector *connector = &ge_b850v3_lvds_ptr->connector;
		int ret;

		if (!bridge->encoder) {
		DRM_ERROR("Parent encoder object not found");
		return -ENODEV;
		}

		connector->polled = DRM_CONNECTOR_POLL_HPD;

		drm_connector_helper_add(connector,
		&ge_b850v3_lvds_connector_helper_funcs);

		ret = drm_connector_init(bridge->dev, connector,
		&ge_b850v3_lvds_connector_funcs,
		DRM_MODE_CONNECTOR_DisplayPort);
		if (ret) {
		DRM_ERROR("Failed to initialize connector with drm\n");
		return ret;
		}

		return drm_connector_attach_encoder(connector, bridge->encoder);
		}

		static irqreturn_t ge_b850v3_lvds_irq_handler(int irq, void *dev_id)
		{
		struct i2c_client *stdp4028_i2c
		@@ -209,7 +235,6 @@ static irqreturn_t ge_b850v3_lvds_irq_handler(int irq, void *dev_id)
		static int ge_b850v3_lvds_attach(struct drm_bridge *bridge,
		enum drm_bridge_attach_flags flags)
		{
		struct drm_connector *connector = &ge_b850v3_lvds_ptr->connector;
		struct i2c_client *stdp4028_i2c
		= ge_b850v3_lvds_ptr->stdp4028_i2c;
		int ret;
		@@ -219,25 +244,7 @@ static int ge_b850v3_lvds_attach(struct drm_bridge *bridge,
		return -EINVAL;
		}

		if (!bridge->encoder) {
		DRM_ERROR("Parent encoder object not found");
		return -ENODEV;
		}

		connector->polled = DRM_CONNECTOR_POLL_HPD;

		drm_connector_helper_add(connector,
		&ge_b850v3_lvds_connector_helper_funcs);

		ret = drm_connector_init(bridge->dev, connector,
		&ge_b850v3_lvds_connector_funcs,
		DRM_MODE_CONNECTOR_DisplayPort);
		if (ret) {
		DRM_ERROR("Failed to initialize connector with drm\n");
		return ret;
		}

		ret = drm_connector_attach_encoder(connector, bridge->encoder);
		ret = ge_b850v3_lvds_create_connector(bridge);
		if (ret)
		return ret;

Admin message