Commit 43c3dd08 authored Jul 03, 2015 by Matthew Wilcox Committed by Al Viro Jul 04, 2015

dax: bdev_direct_access() may sleep



The brd driver is the only in-tree driver that may sleep currently.
After some discussion on linux-fsdevel, we decided that any driver
may choose to sleep in its ->direct_access method.  To ensure that all
callers of bdev_direct_access() are prepared for this, add a call
to might_sleep().

Signed-off-by: Matthew Wilcox <matthew.r.wilcox@intel.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

parent bbab37dd

fs/block_dev.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -445,6 +445,12 @@ long bdev_direct_access(struct block_device *bdev, sector_t sector,
		long avail;
		const struct block_device_operations *ops = bdev->bd_disk->fops;

		/*
		* The device driver is allowed to sleep, in order to make the
		* memory directly accessible.
		*/
		might_sleep();

		if (size < 0)
		return size;
		if (!ops->direct_access)

Admin message