Commit 43b9ac93 authored Jul 31, 2019 by Greg Kroah-Hartman

firmware: arm_scpi: convert platform driver to use dev_groups



Platform drivers now have the option to have the platform core create
and remove any needed sysfs attribute files.  So take advantage of that
and do not register "by hand" a sysfs group of attributes.

Acked-by: Sudeep Holla <sudeep.holla@arm.com>
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://lore.kernel.org/r/20190731124349.4474-6-gregkh@linuxfoundation.org


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 0682e005

drivers/firmware/arm_scpi.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -1011,10 +1011,6 @@ static int scpi_probe(struct platform_device *pdev)
		scpi_info->firmware_version));
		scpi_info->scpi_ops = &scpi_ops;

		ret = devm_device_add_groups(dev, versions_groups);
		if (ret)
		dev_err(dev, "unable to create sysfs version group\n");

		return devm_of_platform_populate(dev);
		}

		@@ -1030,6 +1026,7 @@ static struct platform_driver scpi_driver = {
		.driver = {
		.name = "scpi_protocol",
		.of_match_table = scpi_of_match,
		.dev_groups = versions_groups,
		},
		.probe = scpi_probe,
		.remove = scpi_remove,

Admin message