Commit 43af2146 authored Nov 17, 2017 by Greg Kroah-Hartman Committed by Martin K. Petersen Dec 04, 2017

scsi: csiostor: remove unneeded DRIVER_LICENSE #define



There is no need to #define the license of the driver, just put it in
the MODULE_LICENSE() line directly as a text string.

This allows tools that check that the module license matches the source
code license to work properly, as there is no need to unwind the
unneeded dereference, especially when the string is defined in a .h file
far away from the .c file it is used in.

Cc: "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Varun Prakash <varun@chelsio.com>
Reported-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 07ffd4ce

drivers/scsi/csiostor/csio_init.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1258,7 +1258,7 @@ module_init(csio_init);
		module_exit(csio_exit);
		MODULE_AUTHOR(CSIO_DRV_AUTHOR);
		MODULE_DESCRIPTION(CSIO_DRV_DESC);
		MODULE_LICENSE(CSIO_DRV_LICENSE);
		MODULE_LICENSE("Dual BSD/GPL");
		MODULE_DEVICE_TABLE(pci, csio_pci_tbl);
		MODULE_VERSION(CSIO_DRV_VERSION);
		MODULE_FIRMWARE(FW_FNAME_T5);

drivers/scsi/csiostor/csio_init.h

+0 −1

Original line number	Diff line number	Diff line
		@@ -48,7 +48,6 @@
		#include "csio_hw.h"

		#define CSIO_DRV_AUTHOR "Chelsio Communications"
		#define CSIO_DRV_LICENSE "Dual BSD/GPL"
		#define CSIO_DRV_DESC "Chelsio FCoE driver"
		#define CSIO_DRV_VERSION "1.0.0-ko"

Admin message