Commit 438f3d13 authored by Stanislaw Gruszka's avatar Stanislaw Gruszka Committed by Kalle Valo
Browse files

iwlegacy: warn when enabling power save 



iwlegacy firmware can crash when power save is configured. PS was
allowed in "dbdac2b5 iwlegacy: properly enable power saving" with belive
that user who enable PS is aware of that and can relate firmware crahes
with PS. However some distributions seems to enable PS without user
intervention, so warn about that.

Signed-off-by: default avatarStanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent 4a4274bf

drivers/net/wireless/intel/iwlegacy/common.c

+2 −0
Original line number Diff line number Diff line
@@ -5147,6 +5147,8 @@ set_ch_out: 


	if (changed & (IEEE80211_CONF_CHANGE_PS | IEEE80211_CONF_CHANGE_IDLE)) {

		il->power_data.ps_disabled = !(conf->flags & IEEE80211_CONF_PS);

		if (!il->power_data.ps_disabled)

			IL_WARN_ONCE("Enabling power save might cause firmware crashes\n");

		ret = il_power_update_mode(il, false);

		if (ret)

			D_MAC80211("Error setting sleep level\n");

drivers/net/wireless/intel/iwlegacy/common.h

+1 −0
Original line number Diff line number Diff line
@@ -45,6 +45,7 @@ struct il_tx_queue; 


#define IL_ERR(f, a...) dev_err(&il->pci_dev->dev, f, ## a)

#define IL_WARN(f, a...) dev_warn(&il->pci_dev->dev, f, ## a)

#define IL_WARN_ONCE(f, a...) dev_warn_once(&il->pci_dev->dev, f, ## a)

#define IL_INFO(f, a...) dev_info(&il->pci_dev->dev, f, ## a)



#define RX_QUEUE_SIZE                         256

CRA Git | Maintained and supported by SUSTech CRA and CCSE