Commit 438ab720 authored by Kirill Smelkov's avatar Kirill Smelkov
Browse files

vfs: pass ppos=NULL to .read()/.write() of FMODE_STREAM files 



This amends commit 10dce8af ("fs: stream_open - opener for
stream-like files so that read and write can run simultaneously without
deadlock") in how position is passed into .read()/.write() handler for
stream-like files:

Rasmus noticed that we currently pass 0 as position and ignore any position
change if that is done by a file implementation. This papers over bugs if ppos
is used in files that declare themselves as being stream-like as such bugs will
go unnoticed. Even if a file implementation is correctly converted into using
stream_open, its read/write later could be changed to use ppos and even though
that won't be working correctly, that bug might go unnoticed without someone
doing wrong behaviour analysis. It is thus better to pass ppos=NULL into
read/write for stream-like files as that don't give any chance for ppos usage
bugs because it will oops if ppos is ever used inside .read() or .write().

Note 1: rw_verify_area, new_sync_{read,write} needs to be updated
because they are called by vfs_read/vfs_write & friends before
file_operations .read/.write .

Note 2: if file backend uses new-style .read_iter/.write_iter, position
is still passed into there as non-pointer kiocb.ki_pos . Currently
stream_open.cocci (semantic patch added by 10dce8af) ignores files
whose file_operations has *_iter methods.

Suggested-by: default avatarRasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: default avatarKirill Smelkov <kirr@nexedi.com>
parent c5bf68fe

fs/open.c

+3 −2
Original line number Diff line number Diff line
@@ -1219,8 +1219,9 @@ EXPORT_SYMBOL(nonseekable_open); 
/*

 * stream_open is used by subsystems that want stream-like file descriptors.

 * Such file descriptors are not seekable and don't have notion of position

 * (file.f_pos is always 0). Contrary to file descriptors of other regular

 * files, .read() and .write() can run simultaneously.

 * (file.f_pos is always 0 and ppos passed to .read()/.write() is always NULL).

 * Contrary to file descriptors of other regular files, .read() and .write()

 * can run simultaneously.

 *

 * stream_open never fails and is marked to return int so that it could be

 * directly used as file_operations.open .

fs/read_write.c

+67 −46
Original line number Diff line number Diff line
@@ -365,13 +365,19 @@ out_putf: 
int rw_verify_area(int read_write, struct file *file, const loff_t *ppos, size_t count)

{

	struct inode *inode;

	loff_t pos;

	int retval = -EINVAL;



	inode = file_inode(file);

	if (unlikely((ssize_t) count < 0))

		return retval;

	pos = *ppos;



	/*

	 * ranged mandatory locking does not apply to streams - it makes sense

	 * only for files where position has a meaning.

	 */

	if (ppos) {

		loff_t pos = *ppos;



		if (unlikely(pos < 0)) {

			if (!unsigned_offsets(file))

				return retval;
@@ -388,6 +394,8 @@ int rw_verify_area(int read_write, struct file *file, const loff_t *ppos, size_t 
			if (retval < 0)

				return retval;

		}

	}



	return security_file_permission(file,

				read_write == READ ? MAY_READ : MAY_WRITE);

}
@@ -400,11 +408,12 @@ static ssize_t new_sync_read(struct file *filp, char __user *buf, size_t len, lo 
	ssize_t ret;



	init_sync_kiocb(&kiocb, filp);

	kiocb.ki_pos = *ppos;

	kiocb.ki_pos = (ppos ? *ppos : 0);

	iov_iter_init(&iter, READ, &iov, 1, len);



	ret = call_read_iter(filp, &kiocb, &iter);

	BUG_ON(ret == -EIOCBQUEUED);

	if (ppos)

		*ppos = kiocb.ki_pos;

	return ret;

}
@@ -468,12 +477,12 @@ static ssize_t new_sync_write(struct file *filp, const char __user *buf, size_t 
	ssize_t ret;



	init_sync_kiocb(&kiocb, filp);

	kiocb.ki_pos = *ppos;

	kiocb.ki_pos = (ppos ? *ppos : 0);

	iov_iter_init(&iter, WRITE, &iov, 1, len);



	ret = call_write_iter(filp, &kiocb, &iter);

	BUG_ON(ret == -EIOCBQUEUED);

	if (ret > 0)

	if (ret > 0 && ppos)

		*ppos = kiocb.ki_pos;

	return ret;

}
@@ -558,15 +567,10 @@ ssize_t vfs_write(struct file *file, const char __user *buf, size_t count, loff_ 
	return ret;

}



static inline loff_t file_pos_read(struct file *file)

{

	return file->f_mode & FMODE_STREAM ? 0 : file->f_pos;

}



static inline void file_pos_write(struct file *file, loff_t pos)

/* file_ppos returns &file->f_pos or NULL if file is stream */

static inline loff_t *file_ppos(struct file *file)

{

	if ((file->f_mode & FMODE_STREAM) == 0)

		file->f_pos = pos;

	return file->f_mode & FMODE_STREAM ? NULL : &file->f_pos;

}



ssize_t ksys_read(unsigned int fd, char __user *buf, size_t count)
@@ -575,10 +579,14 @@ ssize_t ksys_read(unsigned int fd, char __user *buf, size_t count) 
	ssize_t ret = -EBADF;



	if (f.file) {

		loff_t pos = file_pos_read(f.file);

		ret = vfs_read(f.file, buf, count, &pos);

		if (ret >= 0)

			file_pos_write(f.file, pos);

		loff_t pos, *ppos = file_ppos(f.file);

		if (ppos) {

			pos = *ppos;

			ppos = &pos;

		}

		ret = vfs_read(f.file, buf, count, ppos);

		if (ret >= 0 && ppos)

			f.file->f_pos = pos;

		fdput_pos(f);

	}

	return ret;
@@ -595,10 +603,14 @@ ssize_t ksys_write(unsigned int fd, const char __user *buf, size_t count) 
	ssize_t ret = -EBADF;



	if (f.file) {

		loff_t pos = file_pos_read(f.file);

		ret = vfs_write(f.file, buf, count, &pos);

		if (ret >= 0)

			file_pos_write(f.file, pos);

		loff_t pos, *ppos = file_ppos(f.file);

		if (ppos) {

			pos = *ppos;

			ppos = &pos;

		}

		ret = vfs_write(f.file, buf, count, ppos);

		if (ret >= 0 && ppos)

			f.file->f_pos = pos;

		fdput_pos(f);

	}
@@ -673,13 +685,14 @@ static ssize_t do_iter_readv_writev(struct file *filp, struct iov_iter *iter, 
	ret = kiocb_set_rw_flags(&kiocb, flags);

	if (ret)

		return ret;

	kiocb.ki_pos = *ppos;

	kiocb.ki_pos = (ppos ? *ppos : 0);



	if (type == READ)

		ret = call_read_iter(filp, &kiocb, iter);

	else

		ret = call_write_iter(filp, &kiocb, iter);

	BUG_ON(ret == -EIOCBQUEUED);

	if (ppos)

		*ppos = kiocb.ki_pos;

	return ret;

}
@@ -1013,10 +1026,14 @@ static ssize_t do_readv(unsigned long fd, const struct iovec __user *vec, 
	ssize_t ret = -EBADF;



	if (f.file) {

		loff_t pos = file_pos_read(f.file);

		ret = vfs_readv(f.file, vec, vlen, &pos, flags);

		if (ret >= 0)

			file_pos_write(f.file, pos);

		loff_t pos, *ppos = file_ppos(f.file);

		if (ppos) {

			pos = *ppos;

			ppos = &pos;

		}

		ret = vfs_readv(f.file, vec, vlen, ppos, flags);

		if (ret >= 0 && ppos)

			f.file->f_pos = pos;

		fdput_pos(f);

	}
@@ -1033,10 +1050,14 @@ static ssize_t do_writev(unsigned long fd, const struct iovec __user *vec, 
	ssize_t ret = -EBADF;



	if (f.file) {

		loff_t pos = file_pos_read(f.file);

		ret = vfs_writev(f.file, vec, vlen, &pos, flags);

		if (ret >= 0)

			file_pos_write(f.file, pos);

		loff_t pos, *ppos = file_ppos(f.file);

		if (ppos) {

			pos = *ppos;

			ppos = &pos;

		}

		ret = vfs_writev(f.file, vec, vlen, ppos, flags);

		if (ret >= 0 && ppos)

			f.file->f_pos = pos;

		fdput_pos(f);

	}

CRA Git | Maintained and supported by SUSTech CRA and CCSE