Unverified Commit 4378f1fb authored by Peter Ujfalusi's avatar Peter Ujfalusi Committed by Mark Brown
Browse files

ASoC: soc-pcm: Use different sequence for start/stop trigger 



On stream stop currently we stop the DMA first followed by the CPU DAI.
This can cause underflow (playback) or overflow (capture) on the DAI side
as the DMA is no longer feeding data while the DAI is still active.
It can be observed easily if the DAI side does not have FIFO (or it is
disabled) to survive the time while the DMA is stopped, but still can
happen on relatively slow CPUs when relatively high sampling rate is used:
the FIFO is drained between the time the DMA is stopped and the DAI is
stopped.

It can only fixed by using different sequence within trigger for 'stop' and
'start':
case SNDRV_PCM_TRIGGER_START:
case SNDRV_PCM_TRIGGER_RESUME:
case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
	Trigger order: dai_link, DMA, CPU DAI then the codec

case SNDRV_PCM_TRIGGER_STOP:
case SNDRV_PCM_TRIGGER_SUSPEND:
case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
	Trigger order: codec, CPU DAI, DMA then dai_link

Signed-off-by: default avatarPeter Ujfalusi <peter.ujfalusi@ti.com>
Reviewed-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20190927071646.22319-1-peter.ujfalusi@ti.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 703df441

sound/soc/soc-pcm.c

+61 −3
Original line number Diff line number Diff line
@@ -1047,7 +1047,7 @@ static int soc_pcm_hw_free(struct snd_pcm_substream *substream) 
	return 0;

}



static int soc_pcm_trigger(struct snd_pcm_substream *substream, int cmd)

static int soc_pcm_trigger_start(struct snd_pcm_substream *substream, int cmd)

{

	struct snd_soc_pcm_runtime *rtd = substream->private_data;

	struct snd_soc_component *component;
@@ -1056,8 +1056,8 @@ static int soc_pcm_trigger(struct snd_pcm_substream *substream, int cmd) 
	struct snd_soc_dai *codec_dai;

	int i, ret;



	for_each_rtd_codec_dai(rtd, i, codec_dai) {

		ret = snd_soc_dai_trigger(codec_dai, substream, cmd);

	if (rtd->dai_link->ops->trigger) {

		ret = rtd->dai_link->ops->trigger(substream, cmd);

		if (ret < 0)

			return ret;

	}
@@ -1074,6 +1074,42 @@ static int soc_pcm_trigger(struct snd_pcm_substream *substream, int cmd) 
	if (ret < 0)

		return ret;



	for_each_rtd_codec_dai(rtd, i, codec_dai) {

		ret = snd_soc_dai_trigger(codec_dai, substream, cmd);

		if (ret < 0)

			return ret;

	}



	return 0;

}



static int soc_pcm_trigger_stop(struct snd_pcm_substream *substream, int cmd)

{

	struct snd_soc_pcm_runtime *rtd = substream->private_data;

	struct snd_soc_component *component;

	struct snd_soc_rtdcom_list *rtdcom;

	struct snd_soc_dai *cpu_dai = rtd->cpu_dai;

	struct snd_soc_dai *codec_dai;

	int i, ret;



	for_each_rtd_codec_dai(rtd, i, codec_dai) {

		ret = snd_soc_dai_trigger(codec_dai, substream, cmd);

		if (ret < 0)

			return ret;

	}



	ret = snd_soc_dai_trigger(cpu_dai, substream, cmd);

	if (ret < 0)

		return ret;



	for_each_rtdcom(rtd, rtdcom) {

		component = rtdcom->component;



		ret = snd_soc_component_trigger(component, substream, cmd);

		if (ret < 0)

			return ret;

	}



	if (rtd->dai_link->ops->trigger) {

		ret = rtd->dai_link->ops->trigger(substream, cmd);

		if (ret < 0)
@@ -1083,6 +1119,28 @@ static int soc_pcm_trigger(struct snd_pcm_substream *substream, int cmd) 
	return 0;

}



static int soc_pcm_trigger(struct snd_pcm_substream *substream, int cmd)

{

	int ret;



	switch (cmd) {

	case SNDRV_PCM_TRIGGER_START:

	case SNDRV_PCM_TRIGGER_RESUME:

	case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:

		ret = soc_pcm_trigger_start(substream, cmd);

		break;

	case SNDRV_PCM_TRIGGER_STOP:

	case SNDRV_PCM_TRIGGER_SUSPEND:

	case SNDRV_PCM_TRIGGER_PAUSE_PUSH:

		ret = soc_pcm_trigger_stop(substream, cmd);

		break;

	default:

		return -EINVAL;

	}



	return ret;

}



static int soc_pcm_bespoke_trigger(struct snd_pcm_substream *substream,

				   int cmd)

{

CRA Git | Maintained and supported by SUSTech CRA and CCSE