Commit 43776896 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Greg Kroah-Hartman
Browse files

serial: imx: Only handle irqs that are actually enabled 



Handling an irq that isn't enabled can have some undesired side effects.
Some of these are mentioned in the newly introduced code comment. Some
of the irq sources already had their handling right, some don't. Handle
them all in the same consistent way.

The change for USR1_RRDY and USR1_AGTIM drops the check for
dma_is_enabled. This is correct as UCR1_RRDYEN and UCR2_ATEN are always
off if dma is enabled.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: default avatarShawn Guo <shawnguo@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 0399fd61

drivers/tty/serial/imx.c

+32 −6
Original line number Diff line number Diff line
@@ -758,21 +758,47 @@ static void imx_mctrl_check(struct imx_port *sport) 
static irqreturn_t imx_int(int irq, void *dev_id)

{

	struct imx_port *sport = dev_id;

	unsigned int usr1, usr2;

	unsigned int usr1, usr2, ucr1, ucr2, ucr3, ucr4;

	irqreturn_t ret = IRQ_NONE;



	usr1 = readl(sport->port.membase + USR1);

	usr2 = readl(sport->port.membase + USR2);

	ucr1 = readl(sport->port.membase + UCR1);

	ucr2 = readl(sport->port.membase + UCR2);

	ucr3 = readl(sport->port.membase + UCR3);

	ucr4 = readl(sport->port.membase + UCR4);



	if (!sport->dma_is_enabled && (usr1 & (USR1_RRDY | USR1_AGTIM))) {

	/*

	 * Even if a condition is true that can trigger an irq only handle it if

	 * the respective irq source is enabled. This prevents some undesired

	 * actions, for example if a character that sits in the RX FIFO and that

	 * should be fetched via DMA is tried to be fetched using PIO. Or the

	 * receiver is currently off and so reading from URXD0 results in an

	 * exception. So just mask the (raw) status bits for disabled irqs.

	 */

	if ((ucr1 & UCR1_RRDYEN) == 0)

		usr1 &= ~USR1_RRDY;

	if ((ucr2 & UCR2_ATEN) == 0)

		usr1 &= ~USR1_AGTIM;

	if ((ucr1 & UCR1_TXMPTYEN) == 0)

		usr1 &= ~USR1_TRDY;

	if ((ucr4 & UCR4_TCEN) == 0)

		usr2 &= ~USR2_TXDC;

	if ((ucr3 & UCR3_DTRDEN) == 0)

		usr1 &= ~USR1_DTRD;

	if ((ucr1 & UCR1_RTSDEN) == 0)

		usr1 &= ~USR1_RTSD;

	if ((ucr3 & UCR3_AWAKEN) == 0)

		usr1 &= ~USR1_AWAKE;

	if ((ucr4 & UCR4_OREN) == 0)

		usr2 &= ~USR2_ORE;



	if (usr1 & (USR1_RRDY | USR1_AGTIM)) {

		imx_rxint(irq, dev_id);

		ret = IRQ_HANDLED;

	}



	if ((usr1 & USR1_TRDY &&

	     readl(sport->port.membase + UCR1) & UCR1_TXMPTYEN) ||

	    (usr2 & USR2_TXDC &&

	     readl(sport->port.membase + UCR4) & UCR4_TCEN)) {

	if ((usr1 & USR1_TRDY) || (usr2 & USR2_TXDC)) {

		imx_txint(irq, dev_id);

		ret = IRQ_HANDLED;

	}

CRA Git | Maintained and supported by SUSTech CRA and CCSE