Commit 436e9c1b authored by Larry Finger's avatar Larry Finger Committed by Kalle Valo
Browse files

rtlwifi: btcoex: Remove 92e 2ant configuration parameter 



In file halbtc8192e2ant.c, there are directives that depend on an
undocumented configuration parameter BT_AUTO_REPORT_ONLY_8192E_2ANT
that cannot be set from Kconfig. This parameter is replaced by a
boolean in the main structure used by all routines. It still cannot
be changed dynamically, but it is easier to document.

Upon the advice of Realtek, the auto report option is turned on with
this patch.

Routine btc8192e2ant_is_wifi_status_changed() is restored.

Signed-off-by: default avatarLarry Finger <Larry.Finger@lwfinger.net>
Cc: Yan-Hsuan Chuang <yhchuang@realtek.com>
Cc: Pkshih <pkshih@realtek.com>
Cc: Birming Chiu <birming@realtek.com>
Cc: Shaofu <shaofu@realtek.com>
Cc: Steven Ting <steventing@realtek.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent d6a82054

drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8192e2ant.c

+49 −19
Original line number Diff line number Diff line
@@ -456,6 +456,39 @@ static void btc8192e2ant_query_bt_info(struct btc_coexist *btcoexist) 
	btcoexist->btc_fill_h2c(btcoexist, 0x61, 1, h2c_parameter);

}



static

bool btc8192e2ant_is_wifi_status_changed(struct btc_coexist *btcoexist)

{

	static bool pre_wifi_busy = false, pre_under_4way = false,

		    pre_bt_hs_on = false;

	bool wifi_busy = false, under_4way = false, bt_hs_on = false;

	bool wifi_connected = false;



	btcoexist->btc_get(btcoexist, BTC_GET_BL_WIFI_CONNECTED,

			   &wifi_connected);

	btcoexist->btc_get(btcoexist, BTC_GET_BL_WIFI_BUSY, &wifi_busy);

	btcoexist->btc_get(btcoexist, BTC_GET_BL_HS_OPERATION, &bt_hs_on);

	btcoexist->btc_get(btcoexist, BTC_GET_BL_WIFI_4_WAY_PROGRESS,

			   &under_4way);



	if (wifi_connected) {

		if (wifi_busy != pre_wifi_busy) {

			pre_wifi_busy = wifi_busy;

			return true;

		}

		if (under_4way != pre_under_4way) {

			pre_under_4way = under_4way;

			return true;

		}

		if (bt_hs_on != pre_bt_hs_on) {

			pre_bt_hs_on = bt_hs_on;

			return true;

		}

	}



	return false;

}



static void btc8192e2ant_update_bt_link_info(struct btc_coexist *btcoexist)

{

	struct btc_bt_link_info *bt_link_info = &btcoexist->bt_link_info;
@@ -2886,9 +2919,8 @@ void ex_btc8192e2ant_display_coex_info(struct btc_coexist *btcoexist) 
	RT_TRACE(rtlpriv, COMP_INIT, DBG_DMESG, "\r\n %-35s = %d/ %d",

		 "0x774(lp rx[31:16]/tx[15:0])",

		 coex_sta->low_priority_rx, coex_sta->low_priority_tx);

#if (BT_AUTO_REPORT_ONLY_8192E_2ANT == 1)

	if (btcoexist->auto_report_2ant)

		btc8192e2ant_monitor_bt_ctr(btcoexist);

#endif

	btcoexist->btc_disp_dbg_msg(btcoexist, BTC_DBG_DISP_COEX_STATISTICS);

}
@@ -3078,14 +3110,12 @@ void ex_btc8192e2ant_bt_info_notify(struct btc_coexist *btcoexist, 
			 */

		}



#if (BT_AUTO_REPORT_ONLY_8192E_2ANT == 0)

		if ((coex_sta->bt_info_ext & BIT4)) {

			/* BT auto report already enabled, do nothing */

		} else {

			btc8192e2ant_bt_auto_report(btcoexist, FORCE_EXEC,

		if (!btcoexist->auto_report_2ant) {

			if (!(coex_sta->bt_info_ext & BIT4))

				btc8192e2ant_bt_auto_report(btcoexist,

							    FORCE_EXEC,

							    true);

		}

#endif

	}



	/* check BIT2 first ==> check if bt is under inquiry or page scan */
@@ -3207,13 +3237,13 @@ void ex_btc8192e2ant_periodical(struct btc_coexist *btcoexist) 
			 "************************************************\n");

	}



#if (BT_AUTO_REPORT_ONLY_8192E_2ANT == 0)

	if (!btcoexist->auto_report_2ant) {

		btc8192e2ant_query_bt_info(btcoexist);

		btc8192e2ant_monitor_bt_ctr(btcoexist);

		btc8192e2ant_monitor_bt_enable_disable(btcoexist);

#else

	} else {

		if (btc8192e2ant_is_wifi_status_changed(btcoexist) ||

		    coex_dm->auto_tdma_adjust)

			btc8192e2ant_run_coexist_mechanism(btcoexist);

#endif

	}

}

drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8192e2ant.h

+0 −2
Original line number Diff line number Diff line
@@ -25,8 +25,6 @@ 
/*****************************************************************

 *   The following is for 8192E 2Ant BT Co-exist definition

 *****************************************************************/

#define	BT_AUTO_REPORT_ONLY_8192E_2ANT			0



#define	BT_INFO_8192E_2ANT_B_FTP			BIT7

#define	BT_INFO_8192E_2ANT_B_A2DP			BIT6

#define	BT_INFO_8192E_2ANT_B_HID			BIT5

CRA Git | Maintained and supported by SUSTech CRA and CCSE