Commit 43664e14 authored by Marcos Paulo de Souza's avatar Marcos Paulo de Souza Committed by Greg Kroah-Hartman
Browse files

drivers/staging/bcm/InterfaceDld.c: Fix checkpatch warnings 



In the source file there are a lot of warnings. I will send it in parts to be more easy to
review. All the changes in this file its just alignment, and things like that.

Signed-off-by: default avatarMarcos Paulo de Souza <marcos.mage@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent c28a6133

drivers/staging/bcm/InterfaceDld.c

+46 −47
Original line number Diff line number Diff line 
#include "headers.h"





int InterfaceFileDownload( PVOID arg,

                        struct file *flp,

                        unsigned int on_chip_loc)

int InterfaceFileDownload(PVOID arg, struct file *flp, unsigned int on_chip_loc)

{

   // unsigned int    reg=0;

	/*unsigned int reg = 0;*/

	mm_segment_t oldfs = {0};

    int             errno=0, len=0 /*,is_config_file = 0*/;

	int errno = 0, len = 0; /*,is_config_file = 0*/

	loff_t pos = 0;

	PS_INTERFACE_ADAPTER psIntfAdapter = (PS_INTERFACE_ADAPTER)arg;

	//PMINI_ADAPTER Adapter = psIntfAdapter->psAdapter;

	/*PMINI_ADAPTER Adapter = psIntfAdapter->psAdapter;*/

	char *buff = kmalloc(MAX_TRANSFER_CTRL_BYTE_USB, GFP_KERNEL);



	if (!buff)

    {

		return -ENOMEM;

    }

    while(1)

    {

        oldfs=get_fs(); set_fs(get_ds());

        len=vfs_read(flp, (void __force __user *)buff, MAX_TRANSFER_CTRL_BYTE_USB, &pos);



	while (1) {

		oldfs = get_fs();

		set_fs(get_ds());

		len = vfs_read(flp, (void __force __user *)buff,

			       MAX_TRANSFER_CTRL_BYTE_USB, &pos);

		set_fs(oldfs);

        if(len<=0)

        {

            if(len<0)

            {

                BCM_DEBUG_PRINT(psIntfAdapter->psAdapter,DBG_TYPE_INITEXIT, MP_INIT, DBG_LVL_ALL, "len < 0");

		if (len <= 0) {

			if (len < 0) {

				BCM_DEBUG_PRINT(psIntfAdapter->psAdapter,

						DBG_TYPE_INITEXIT, MP_INIT,

						DBG_LVL_ALL, "len < 0");

				errno = len;

            }

            else

            {

			} else {

				errno = 0;

                BCM_DEBUG_PRINT(psIntfAdapter->psAdapter,DBG_TYPE_INITEXIT, MP_INIT, DBG_LVL_ALL, "Got end of file!");

				BCM_DEBUG_PRINT(psIntfAdapter->psAdapter,

						DBG_TYPE_INITEXIT, MP_INIT,

						DBG_LVL_ALL,

						"Got end of file!");

			}

			break;

		}

        //BCM_DEBUG_PRINT_BUFFER(Adapter,DBG_TYPE_INITEXIT, MP_INIT, DBG_LVL_ALL, buff, MAX_TRANSFER_CTRL_BYTE_USB);

		/* BCM_DEBUG_PRINT_BUFFER(Adapter,DBG_TYPE_INITEXIT, MP_INIT,

					  DBG_LVL_ALL, buff,

					  MAX_TRANSFER_CTRL_BYTE_USB);*/

		errno = InterfaceWRM(psIntfAdapter, on_chip_loc, buff, len);

		if(errno)

		{

            BCM_DEBUG_PRINT(psIntfAdapter->psAdapter,DBG_TYPE_PRINTK, 0, 0, "WRM Failed! status: %d", errno);

		if (errno) {

			BCM_DEBUG_PRINT(psIntfAdapter->psAdapter,

					DBG_TYPE_PRINTK, 0, 0,

					"WRM Failed! status: %d", errno);

			break;



		}

		on_chip_loc += MAX_TRANSFER_CTRL_BYTE_USB;

	}/* End of for(;;)*/

	}



	kfree(buff);

	return errno;

}



int InterfaceFileReadbackFromChip( PVOID arg,

                        struct file *flp,

int InterfaceFileReadbackFromChip(PVOID arg, struct file *flp,

				  unsigned int on_chip_loc)

{

	char *buff, *buff_readback;

CRA Git | Maintained and supported by SUSTech CRA and CCSE