sound_firmware: don't bother with filp_close() (434b5a2e) · Commits · 戴 / test

sound/sound_firmware.c

+5 −4

Original line number	Diff line number	Diff line
		#include <linux/vmalloc.h>
		#include <linux/module.h>
		#include <linux/fs.h>
		#include <linux/file.h>
		#include <linux/mm.h>
		#include <linux/sched.h>
		#include <asm/uaccess.h>
		@@ -23,14 +24,14 @@ static int do_mod_firmware_load(const char fn, char *fp)
		if (l <= 0 \|\| l > 131072)
		{
		printk(KERN_INFO "Invalid firmware '%s'\n", fn);
		filp_close(filp, NULL);
		fput(filp);
		return 0;
		}
		dp = vmalloc(l);
		if (dp == NULL)
		{
		printk(KERN_INFO "Out of memory loading '%s'.\n", fn);
		filp_close(filp, NULL);
		fput(filp);
		return 0;
		}
		pos = 0;
		@@ -38,10 +39,10 @@ static int do_mod_firmware_load(const char fn, char *fp)
		{
		printk(KERN_INFO "Failed to read '%s'.\n", fn);
		vfree(dp);
		filp_close(filp, NULL);
		fput(filp);
		return 0;
		}
		filp_close(filp, NULL);
		fput(filp);
		*fp = dp;
		return (int) l;
		}