Commit 433eba04 authored by Vasu Dev's avatar Vasu Dev Committed by James Bottomley
Browse files

[SCSI] fcoe: remove lport from net device before doing per cpu rx thread cleanup 

Remove lport from net device and then do synchronize net device to flush
inflight rx frames for the lport before doing fcoe_percpu_clean.

In case of master lport, remove all rx packet handlers completely and
then only do fcoe_percpu_clean. This required splitting fcoe_interface_cleanup
to do remove part separately and for that added func fcoe_interface_remove
and then  call it from fcoe_if_destory before doing fcoe_percpu_clean.
However if fcoe_interface_remove() is already called then
don't call again from fcoe_interface_cleanup() to preserve its
existing flows.

This patch along with Neil's other patch to avoid soft irq context
on ingress will avoid passing up frames on disabled lport as
discussed in this mail thread:-
http://lists.open-fcoe.org/pipermail/devel/2012-February/011947.html



Signed-off-by: default avatarVasu Dev <vasu.dev@intel.com>
Acked-by: default avatarNeil Horman <nhorman@tuxdriver.com>
Tested-by: default avatarRoss Brattain <ross.b.brattain@intel.com>
Signed-off-by: default avatarRobert Love <robert.w.love@intel.com>
Signed-off-by: default avatarJames Bottomley <JBottomley@Parallels.com>
parent 9941fa6e

drivers/scsi/fcoe/fcoe.c

+21 −4
Original line number Diff line number Diff line
@@ -411,20 +411,18 @@ out: 
}



/**

 * fcoe_interface_cleanup() - Clean up a FCoE interface

 * fcoe_interface_remove() - remove FCoE interface from netdev

 * @fcoe: The FCoE interface to be cleaned up

 *

 * Caller must be holding the RTNL mutex

 */

static void fcoe_interface_cleanup(struct fcoe_interface *fcoe)

static void fcoe_interface_remove(struct fcoe_interface *fcoe)

{

	struct net_device *netdev = fcoe->netdev;

	struct fcoe_ctlr *fip = &fcoe->ctlr;

	u8 flogi_maddr[ETH_ALEN];

	const struct net_device_ops *ops;



	rtnl_lock();



	/*

	 * Don't listen for Ethernet packets anymore.

	 * synchronize_net() ensures that the packet handlers are not running
@@ -453,7 +451,22 @@ static void fcoe_interface_cleanup(struct fcoe_interface *fcoe) 
			FCOE_NETDEV_DBG(netdev, "Failed to disable FCoE"

					" specific feature for LLD.\n");

	}

	fcoe->removed = 1;

}





/**

 * fcoe_interface_cleanup() - Clean up a FCoE interface

 * @fcoe: The FCoE interface to be cleaned up

 */

static void fcoe_interface_cleanup(struct fcoe_interface *fcoe)

{

	struct net_device *netdev = fcoe->netdev;

	struct fcoe_ctlr *fip = &fcoe->ctlr;



	rtnl_lock();

	if (!fcoe->removed)

		fcoe_interface_remove(fcoe);

	rtnl_unlock();



	/* Release the self-reference taken during fcoe_interface_create() */
@@ -941,6 +954,10 @@ static void fcoe_if_destroy(struct fc_lport *lport) 
	rtnl_lock();

	if (!is_zero_ether_addr(port->data_src_addr))

		dev_uc_del(netdev, port->data_src_addr);

	if (lport->vport)

		synchronize_net();

	else

		fcoe_interface_remove(fcoe);

	rtnl_unlock();



	/* Free queued packets for the per-CPU receive threads */

drivers/scsi/fcoe/fcoe.h

+3 −1
Original line number Diff line number Diff line
@@ -71,7 +71,8 @@ do { \ 
 * @ctlr:	      The FCoE controller (for FIP)

 * @oem:	      The offload exchange manager for all local port

 *		      instances associated with this port

 * This structure is 1:1 with a net devive.

 * @removed:	      Indicates fcoe interface removed from net device

 * This structure is 1:1 with a net device.

 */

struct fcoe_interface {

	struct list_head   list;
@@ -81,6 +82,7 @@ struct fcoe_interface { 
	struct packet_type fip_packet_type;

	struct fcoe_ctlr   ctlr;

	struct fc_exch_mgr *oem;

	u8	removed;

};



#define fcoe_from_ctlr(fip) container_of(fip, struct fcoe_interface, ctlr)

CRA Git | Maintained and supported by SUSTech CRA and CCSE