Unverified Commit 4332ea8f authored May 04, 2020 by Lukas Wunner Committed by Mark Brown May 04, 2020

spi: amd: Drop duplicate driver data assignments



The AMD SPI driver calls platform_set_drvdata() on probe even though
it's already been set by __spi_alloc_controller().  Likewise, it calls
platform_set_drvdata() on remove even though it's going to be set by
__device_release_driver().  Drop the duplicate assignments.

Signed-off-by: Lukas Wunner <lukas@wunner.de>
Link: https://lore.kernel.org/r/499f8ad4759c2ff0f586e0459fb9a293faecff6d.1588590210.git.lukas@wunner.de


Signed-off-by: Mark Brown <broonie@kernel.org>

parent cc17fbec

drivers/spi/spi-amd.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -287,7 +287,6 @@ static int amd_spi_probe(struct platform_device *pdev)
		dev_err(dev, "error %d registering SPI controller\n", err);
		goto err_free_master;
		}
		platform_set_drvdata(pdev, amd_spi);

		return 0;

		@@ -303,7 +302,6 @@ static int amd_spi_remove(struct platform_device *pdev)

		spi_unregister_master(amd_spi->master);
		spi_master_put(amd_spi->master);
		platform_set_drvdata(pdev, NULL);

		return 0;
		}

Admin message