Commit 4311fa60 authored Jun 22, 2006 by Dave Jones Committed by James Bottomley Jun 26, 2006

[SCSI] kmalloc argument switcheroo in recent 53c700 change.



On Wed, Jun 21, 2006 at 07:00:34PM +0000, Linux Kernel wrote:
 > commit 67d59dfd
 > tree ae85703651d81740f4a6cd398f9dd4d6aabe6a2f
 > parent 6db874fb
 > author James Bottomley <James.Bottomley@steeleye.com> Wed, 14 Jun 2006 07:31:19 -0500
 > committer James Bottomley <jejb@mulgrave.il.steeleye.com> Tue, 20 Jun 2006 05:34:01 -0500
 >
 > [SCSI] 53c700: remove reliance on deprecated cmnd fields
 >  ...
 >
 > +	SDp->hostdata = kmalloc(GFP_KERNEL, sizeof(struct NCR_700_sense));
 > +
 > +	if (!SDp->hostdata)
 > +		return -ENOMEM;

"I'll take reversed arguments for $100 please Alex".

Signed-off-by: Dave Jones <davej@redhat.com>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>

parent fcc18e83

drivers/scsi/53c700.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2044,7 +2044,7 @@ NCR_700_slave_configure(struct scsi_device *SDp)
		struct NCR_700_Host_Parameters *hostdata =
		(struct NCR_700_Host_Parameters *)SDp->host->hostdata[0];

		SDp->hostdata = kmalloc(GFP_KERNEL, sizeof(struct NCR_700_sense));
		SDp->hostdata = kmalloc(sizeof(struct NCR_700_sense), GFP_KERNEL);

		if (!SDp->hostdata)
		return -ENOMEM;

Admin message