Commit 42fd8baa authored Sep 17, 2019 by Qian Cai Committed by Ingo Molnar Sep 18, 2019

sched/core: Convert vcpu_is_preempted() from macro to an inline function



Clang reports this warning:

  kernel/locking/osq_lock.c:25:19: warning: unused function 'node_cpu' [-Wunused-function]

due to osq_lock() calling vcpu_is_preempted(node_cpu(node->prev))), but
vcpu_is_preempted() is compiled away. Fix it by converting the dummy
vcpu_is_preempted() from a macro to a proper static inline function.

Signed-off-by: Qian Cai <cai@lca.pw>
Acked-by: Mel Gorman <mgorman@suse.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: bsegall@google.com
Cc: dietmar.eggemann@arm.com
Cc: juri.lelli@redhat.com
Cc: rostedt@goodmis.org
Cc: vincent.guittot@linaro.org
Link: https://lkml.kernel.org/r/1568730894-10483-1-git-send-email-cai@lca.pw


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent dac9f027

include/linux/sched.h

+4 −1

Original line number	Diff line number	Diff line
		@@ -1856,7 +1856,10 @@ static inline void set_task_cpu(struct task_struct *p, unsigned int cpu)
		* running or not.
		*/
		#ifndef vcpu_is_preempted
		# define vcpu_is_preempted(cpu) false
		static inline bool vcpu_is_preempted(int cpu)
		{
		return false;
		}
		#endif

		extern long sched_setaffinity(pid_t pid, const struct cpumask *new_mask);

Admin message