nfp: fix port stats for mac representors (42d779ff) · Commits · 戴 / test

Previously we swapped the tx_packets, tx_bytes and tx_dropped counters with rx_packets, rx_bytes and rx_dropped counters, respectively. This behaviour is correct and expected for VF representors but it should not be swapped for physical port mac representors. Fixes: ("nfp: add stats and xmit helpers for representors") Signed-off-by:

Pieter Jansen van Vuuren <pieter.jansenvanvuuren@netronome.com> Reviewed-by:

Simon Horman <simon.horman@netronome.com> Reviewed-by:

Jakub Kicinski <jakub.kicinski@netronome.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

drivers/net/ethernet/netronome/nfp/nfp_net_repr.c

+6 −9

Original line number	Diff line number	Diff line
		@@ -84,16 +84,13 @@ nfp_repr_phy_port_get_stats64(struct nfp_port *port,
		{
		u8 __iomem *mem = port->eth_stats;

		/* TX and RX stats are flipped as we are returning the stats as seen
		* at the switch port corresponding to the phys port.
		*/
		stats->tx_packets = readq(mem + NFP_MAC_STATS_RX_FRAMES_RECEIVED_OK);
		stats->tx_bytes = readq(mem + NFP_MAC_STATS_RX_IN_OCTETS);
		stats->tx_dropped = readq(mem + NFP_MAC_STATS_RX_IN_ERRORS);
		stats->tx_packets = readq(mem + NFP_MAC_STATS_TX_FRAMES_TRANSMITTED_OK);
		stats->tx_bytes = readq(mem + NFP_MAC_STATS_TX_OUT_OCTETS);
		stats->tx_dropped = readq(mem + NFP_MAC_STATS_TX_OUT_ERRORS);

		stats->rx_packets = readq(mem + NFP_MAC_STATS_TX_FRAMES_TRANSMITTED_OK);
		stats->rx_bytes = readq(mem + NFP_MAC_STATS_TX_OUT_OCTETS);
		stats->rx_dropped = readq(mem + NFP_MAC_STATS_TX_OUT_ERRORS);
		stats->rx_packets = readq(mem + NFP_MAC_STATS_RX_FRAMES_RECEIVED_OK);
		stats->rx_bytes = readq(mem + NFP_MAC_STATS_RX_IN_OCTETS);
		stats->rx_dropped = readq(mem + NFP_MAC_STATS_RX_IN_ERRORS);
		}

		static void

Admin message