Commit 42d5aa76 authored Feb 09, 2017 by Ido Schimmel Committed by David S. Miller Feb 10, 2017

ipv4: fib: Send deletion notification with actual FIB alias type



When a FIB alias is removed, a notification is sent using the type
passed from user space - can be RTN_UNSPEC - instead of the actual type
of the removed alias. This is problematic for listeners of the FIB
notification chain, as several FIB aliases can exist with matching
parameters, but the type.

Solve this by passing the actual type of the removed FIB alias.

Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
CC: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 58e3bdd5

net/ipv4/fib_trie.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1653,8 +1653,8 @@ int fib_table_delete(struct net net, struct fib_table tb,
		return -ESRCH;

		call_fib_entry_notifiers(net, FIB_EVENT_ENTRY_DEL, key, plen,
		fa_to_delete->fa_info, tos, cfg->fc_type,
		tb->tb_id, 0);
		fa_to_delete->fa_info, tos,
		fa_to_delete->fa_type, tb->tb_id, 0);
		rtmsg_fib(RTM_DELROUTE, htonl(key), fa_to_delete, plen, tb->tb_id,
		&cfg->fc_nlinfo, 0);

Admin message