Commit 42cde48b authored Jan 08, 2020 by Sean Christopherson Committed by Paolo Bonzini Jan 27, 2020

KVM: Play nice with read-only memslots when querying host page size



Avoid the "writable" check in __gfn_to_hva_many(), which will always fail
on read-only memslots due to gfn_to_hva() assuming writes.  Functionally,
this allows x86 to create large mappings for read-only memslots that
are backed by HugeTLB mappings.

Note, the changelog for commit 05da4558 ("KVM: MMU: large page
support") states "If the largepage contains write-protected pages, a
large pte is not used.", but "write-protected" refers to pages that are
temporarily read-only, e.g. read-only memslots didn't even exist at the
time.

Fixes: 4d8b81ab ("KVM: introduce readonly memslot")
Cc: stable@vger.kernel.org
Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
[Redone using kvm_vcpu_gfn_to_memslot_prot. - Paolo]
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

parent f9b84e19

virt/kvm/kvm_main.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1409,7 +1409,7 @@ unsigned long kvm_host_page_size(struct kvm_vcpu *vcpu, gfn_t gfn)

		size = PAGE_SIZE;

		addr = kvm_vcpu_gfn_to_hva(vcpu, gfn);
		addr = kvm_vcpu_gfn_to_hva_prot(vcpu, gfn, NULL);
		if (kvm_is_error_hva(addr))
		return PAGE_SIZE;

Admin message