Commit 42c8819b authored by David S. Miller's avatar David S. Miller
Browse files

Merge branch 'tunnel-csum-and-sg-offloads' 



Alexander Duyck says:

====================
Fixes for tunnel checksum and segmentation offloads

This patch series is a subset of patches I had submitted for net-next.  I
plan to drop these two patches from the v3 of "Fix Tunnel features and
enable GSO partial for several drivers" and I am instead submitting them
for net since these are truly fixes and likely will need to be backported
to stable branches.

This series addresses 2 specific issues.  The first is that we could
request TSO on a v4 inner header while not supporting checksum offload of
the outer IPv6 header.  The second is that we could request an IPv6 inner
checksum offload without validating that we could actually support an inner
IPv6 checksum offload.
====================

Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parents 0e28bf93 af67eb9e

include/linux/if_ether.h

+5 −0
Original line number Diff line number Diff line
@@ -28,6 +28,11 @@ static inline struct ethhdr *eth_hdr(const struct sk_buff *skb) 
	return (struct ethhdr *)skb_mac_header(skb);

}



static inline struct ethhdr *inner_eth_hdr(const struct sk_buff *skb)

{

	return (struct ethhdr *)skb_inner_mac_header(skb);

}



int eth_header_parse(const struct sk_buff *skb, unsigned char *haddr);



extern ssize_t sysfs_format_mac(char *buf, const unsigned char *addr, int len);

include/net/vxlan.h

+3 −1
Original line number Diff line number Diff line
@@ -252,7 +252,9 @@ static inline netdev_features_t vxlan_features_check(struct sk_buff *skb, 
	    (skb->inner_protocol_type != ENCAP_TYPE_ETHER ||

	     skb->inner_protocol != htons(ETH_P_TEB) ||

	     (skb_inner_mac_header(skb) - skb_transport_header(skb) !=

	      sizeof(struct udphdr) + sizeof(struct vxlanhdr))))

	      sizeof(struct udphdr) + sizeof(struct vxlanhdr)) ||

	     (skb->ip_summed != CHECKSUM_NONE &&

	      !can_checksum_protocol(features, inner_eth_hdr(skb)->h_proto))))

		return features & ~(NETIF_F_CSUM_MASK | NETIF_F_GSO_MASK);



	return features;

net/core/dev.c

+1 −1
Original line number Diff line number Diff line
@@ -2802,7 +2802,7 @@ static netdev_features_t harmonize_features(struct sk_buff *skb, 


	if (skb->ip_summed != CHECKSUM_NONE &&

	    !can_checksum_protocol(features, type)) {

		features &= ~NETIF_F_CSUM_MASK;

		features &= ~(NETIF_F_CSUM_MASK | NETIF_F_GSO_MASK);

	} else if (illegal_highdma(skb->dev, skb)) {

		features &= ~NETIF_F_SG;

	}

CRA Git | Maintained and supported by SUSTech CRA and CCSE