Commit 42aa15cf authored Aug 28, 2019 by Vivien Didelot Committed by David S. Miller Aug 29, 2019

net: dsa: mv88e6xxx: fix freeing unused SERDES IRQ



Now mv88e6xxx does not enable its ports at setup itself and let
the DSA core handle this, unused ports are disabled without being
powered on first. While that is expected, the SERDES powering code
was assuming that a port was already set up before powering it down,
resulting in freeing an unused IRQ. The patch fixes this assumption.

Fixes: b759f528 ("net: dsa: mv88e6xxx: enable SERDES after setup")
Signed-off-by: Vivien Didelot <vivien.didelot@gmail.com>
Reviewed-by: Marek Behún <marek.behun@nic.cz>
Tested-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 5d24da1e

drivers/net/dsa/mv88e6xxx/chip.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -2070,7 +2070,8 @@ static int mv88e6xxx_serdes_power(struct mv88e6xxx_chip *chip, int port,
		if (chip->info->ops->serdes_irq_setup)
		err = chip->info->ops->serdes_irq_setup(chip, port);
		} else {
		if (chip->info->ops->serdes_irq_free)
		if (chip->info->ops->serdes_irq_free &&
		chip->ports[port].serdes_irq)
		chip->info->ops->serdes_irq_free(chip, port);

		err = chip->info->ops->serdes_power(chip, port, false);

Admin message