Commit 42a10add authored Feb 10, 2008 by Aneesh Kumar K.V Committed by Theodore Ts'o Feb 10, 2008

ext4: Fix null bh pointer dereference in mballoc



Repoted by Adrian Bunk <bunk@kernel.org>:

The Coverity checker spotted the following NULL dereference:

static int ext4_mb_mark_diskspace_used
{
	...
	if (!bitmap_bh)
		goto out_err;
	...
out_err:
	sb->s_dirt = 1;
	put_bh(bitmap_bh);
	...

Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: Mingming Cao <cmm@us.ibm.com>

parent b8356c46

fs/ext4/mballoc.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -3069,7 +3069,7 @@ static int ext4_mb_mark_diskspace_used(struct ext4_allocation_context *ac,

		out_err:
		sb->s_dirt = 1;
		put_bh(bitmap_bh);
		brelse(bitmap_bh);
		return err;
		}

Admin message