Commit 429d33ac authored Nov 24, 2009 by andrew hendry Committed by David S. Miller Nov 29, 2009

X25: Fix oops and refcnt problems from x25_dev_get



Calls to x25_dev_get check for dev = NULL which was not set.
It allowed x25 to set routes and ioctls on down interfaces.
This caused oopses and refcnt problems on device_unregister.

Signed-off-by: Andrew Hendry <andrew.hendry@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 1fd975a0

net/x25/x25_route.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -136,8 +136,10 @@ struct net_device x25_dev_get(char devname)
		#if defined(CONFIG_LLC) \|\| defined(CONFIG_LLC_MODULE)
		&& dev->type != ARPHRD_ETHER
		#endif
		)))
		))){
		dev_put(dev);
		dev = NULL;
		}

		return dev;
		}

Admin message