Commit 42977082 authored May 26, 2015 by Peter Ujfalusi Committed by Vinod Koul Jun 02, 2015

dmaengine: hsu: Fix memory leak when stopping a running transfer



The vd->node is removed from the lists when the transfer started so the
vchan_get_all_descriptors() will not find it. This results memory leak.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
[andy: fix the typo to prevent a compilation error]
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>

parent 81cc6edc

drivers/dma/hsu/hsu.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -384,7 +384,10 @@ static int hsu_dma_terminate_all(struct dma_chan *chan)
		spin_lock_irqsave(&hsuc->vchan.lock, flags);

		hsu_dma_stop_channel(hsuc);
		if (hsuc->desc) {
		hsu_dma_desc_free(&hsuc->desc->vdesc);
		hsuc->desc = NULL;
		}

		vchan_get_all_descriptors(&hsuc->vchan, &head);
		spin_unlock_irqrestore(&hsuc->vchan.lock, flags);

Admin message