Commit 428cd523 authored by Zhang Xiaoxu's avatar Zhang Xiaoxu Committed by Jakub Kicinski
Browse files

sfc/ethtool_common: Make some function to static



Fix sparse warning:

drivers/net/ethernet/sfc/ethtool_common.c
  warning: symbol 'efx_fill_test' was not declared. Should it be static?
  warning: symbol 'efx_fill_loopback_test' was not declared.
           Should it be static?
  warning: symbol 'efx_describe_per_queue_stats' was not declared.
           Should it be static?

Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarZhang Xiaoxu <zhangxiaoxu5@huawei.com>
Reviewed-by: default avatarMartin Habets <mhabets@solarflare.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent e07c5f2e
Loading
Loading
Loading
Loading
+9 −8
Original line number Diff line number Diff line
@@ -147,7 +147,7 @@ void efx_ethtool_get_pauseparam(struct net_device *net_dev,
 *
 * Fill in an individual self-test entry.
 */
void efx_fill_test(unsigned int test_index, u8 *strings, u64 *data,
static void efx_fill_test(unsigned int test_index, u8 *strings, u64 *data,
			  int *test, const char *unit_format, int unit_id,
			  const char *test_format, const char *test_id)
{
@@ -189,10 +189,11 @@ void efx_fill_test(unsigned int test_index, u8 *strings, u64 *data,
 * Fill in a block of loopback self-test entries.  Return new test
 * index.
 */
int efx_fill_loopback_test(struct efx_nic *efx,
static int efx_fill_loopback_test(struct efx_nic *efx,
				  struct efx_loopback_self_tests *lb_tests,
				  enum efx_loopback_mode mode,
			   unsigned int test_index, u8 *strings, u64 *data)
				  unsigned int test_index,
				  u8 *strings, u64 *data)
{
	struct efx_channel *channel =
		efx_get_channel(efx, efx->tx_channel_offset);
@@ -293,7 +294,7 @@ int efx_ethtool_fill_self_tests(struct efx_nic *efx,
	return n;
}

size_t efx_describe_per_queue_stats(struct efx_nic *efx, u8 *strings)
static size_t efx_describe_per_queue_stats(struct efx_nic *efx, u8 *strings)
{
	size_t n_stats = 0;
	struct efx_channel *channel;