Commit 42885551 authored Oct 12, 2018 by Hans de Goede Committed by Thierry Reding Oct 12, 2018

pwm: lpss: Release runtime-pm reference from the driver's remove callback



For each pwm output which gets enabled through pwm_lpss_apply(), we do a
pm_runtime_get_sync().

This commit adds pm_runtime_put() calls to pwm_lpss_remove() to balance
these when the driver gets removed with some of the outputs still enabled.

Fixes: f080be27 ("pwm: lpss: Add support for runtime PM")
Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>

parent 6a425ecd

drivers/pwm/pwm-lpss.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -205,6 +205,12 @@ EXPORT_SYMBOL_GPL(pwm_lpss_probe);

		int pwm_lpss_remove(struct pwm_lpss_chip *lpwm)
		{
		int i;

		for (i = 0; i < lpwm->info->npwm; i++) {
		if (pwm_is_enabled(&lpwm->chip.pwms[i]))
		pm_runtime_put(lpwm->chip.dev);
		}
		return pwmchip_remove(&lpwm->chip);
		}
		EXPORT_SYMBOL_GPL(pwm_lpss_remove);

Admin message