Commit 427cabed authored Mar 15, 2020 by Chuanhong Guo Committed by Bartosz Golaszewski Mar 25, 2020

gpio: mt7621: add BGPIOF_NO_SET_ON_INPUT flag



DSET/DCLR registers only works on output pins. Add corresponding
BGPIOF_NO_SET_ON_INPUT flag to bgpio_init call to fix direction_out
behavior.

Signed-off-by: Chuanhong Guo <gch981213@gmail.com>
Tested-by: René van Dorst <opensource@vdorst.com>
Reviewed-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>

parent d19d2de6

drivers/gpio/gpio-mt7621.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -227,8 +227,8 @@ mediatek_gpio_bank_probe(struct device *dev,
		ctrl = mtk->base + GPIO_REG_DCLR + (rg->bank * GPIO_BANK_STRIDE);
		diro = mtk->base + GPIO_REG_CTRL + (rg->bank * GPIO_BANK_STRIDE);

		ret = bgpio_init(&rg->chip, dev, 4,
		dat, set, ctrl, diro, NULL, 0);
		ret = bgpio_init(&rg->chip, dev, 4, dat, set, ctrl, diro, NULL,
		BGPIOF_NO_SET_ON_INPUT);
		if (ret) {
		dev_err(dev, "bgpio_init() failed\n");
		return ret;

Admin message