Unverified Commit 4276fc82 authored Feb 29, 2020 by Oleksandr Suvorov Committed by Mark Brown Mar 02, 2020

spi: spidev: fix speed setting message



The message of max device speed setting is shown when
an error in spi_setup() occurs.
Instead, it should be shown when the setup call succeeds.

Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
Link: https://lore.kernel.org/r/20200229161841.89144-3-oleksandr.suvorov@toradex.com


Signed-off-by: Mark Brown <broonie@kernel.org>

parent ea70fb5b

drivers/spi/spidev.c

+4 −3

Original line number	Diff line number	Diff line
		@@ -454,10 +454,11 @@ spidev_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)

		spi->max_speed_hz = tmp;
		retval = spi_setup(spi);
		if (retval >= 0)
		if (retval == 0) {
		spidev->speed_hz = tmp;
		else
		dev_dbg(&spi->dev, "%d Hz (max)\n", tmp);
		dev_dbg(&spi->dev, "%d Hz (max)\n",
		spidev->speed_hz);
		}
		spi->max_speed_hz = save;
		}
		break;

Admin message