Commit 4262d35c authored Mar 26, 2019 by Hannes Reinecke Committed by Martin K. Petersen Mar 27, 2019

scsi: qedf: missing kref_put in qedf_xmit()



qedf_xmit() calls fc_rport_lookup(), but discards the returned rdata
structure almost immediately without decreasing the refcount.  This leads
to a refcount leak and the rdata never to be freed.

Signed-off-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Saurav Kashyap <skashyap@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 76dbf4ff

drivers/scsi/qedf/qedf_main.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -971,8 +971,10 @@ static int qedf_xmit(struct fc_lport lport, struct fc_frame fp)
		"Dropping FCoE frame to %06x.\n", ntoh24(fh->fh_d_id));
		kfree_skb(skb);
		rdata = fc_rport_lookup(lport, ntoh24(fh->fh_d_id));
		if (rdata)
		if (rdata) {
		rdata->retries = lport->max_rport_retry_count;
		kref_put(&rdata->kref, fc_rport_destroy);
		}
		return -EINVAL;
		}
		/* End NPIV filtering */

Admin message