Commit 426071f1 authored Nov 06, 2019 by Hoang Le Committed by David S. Miller Nov 06, 2019

tipc: reduce sensitive to retransmit failures



With huge cluster (e.g >200nodes), the amount of that flow:
gap -> retransmit packet -> acked will take time in case of STATE_MSG
dropped/delayed because a lot of traffic. This lead to 1.5 sec tolerance
value criteria made link easy failure around 2nd, 3rd of failed
retransmission attempts.

Instead of re-introduced criteria of 99 faled retransmissions to fix the
issue, we increase failure detection timer to ten times tolerance value.

Fixes: 77cf8edb ("tipc: simplify stale link failure criteria")
Acked-by: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: Hoang Le <hoang.h.le@dektech.com.au>
Acked-by: Jon
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 6708ef77

net/tipc/link.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1087,7 +1087,7 @@ static bool link_retransmit_failure(struct tipc_link l, struct tipc_link r,
		return false;

		if (!time_after(jiffies, TIPC_SKB_CB(skb)->retr_stamp +
		msecs_to_jiffies(r->tolerance)))
		msecs_to_jiffies(r->tolerance * 10)))
		return false;

		hdr = buf_msg(skb);

Admin message