Commit 422edace authored May 11, 2018 by Wang Shilong Committed by Richard Weinberger Jun 07, 2018

ubifs, xattr: remove misguided quota flags



Originally, Yang Dongsheng added quota support
for ubifs, but it turned out upstream won't accept it.

Since ubifs don't touch any quota code, S_NOQUOTA flag
is misguided here, and currently it is mainly used to
avoid recursion for system quota files.

Let's make things clearly and remove unnecessary and
misguied quota flags here.

Reported-by: Rock Lee <rockdotlee@gmail.com>
Signed-off-by: Wang Shilong <wshilong@ddn.com>
Signed-off-by: Richard Weinberger <richard@nod.at>

parent 31c49eac

fs/ubifs/xattr.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -139,7 +139,7 @@ static int create_xattr(struct ubifs_info c, struct inode host,
		inode->i_op = &empty_iops;
		inode->i_fop = &empty_fops;

		inode->i_flags \|= S_SYNC \| S_NOATIME \| S_NOCMTIME \| S_NOQUOTA;
		inode->i_flags \|= S_SYNC \| S_NOATIME \| S_NOCMTIME;
		ui = ubifs_inode(inode);
		ui->xattr = 1;
		ui->flags \|= UBIFS_XATTR_FL;

Admin message