Commit 4226b510 authored Apr 17, 2007 by Andre Renaud Committed by David Woodhouse Apr 17, 2007

[MTD] [NAND] Casting bug in nand_default_block_markbad

There is a slight bug in nand_default_block_markbad, where the offset is
cast to an integer, prior to being shifted. This means that on large
offsets, it is incorrectly doing a signed shift & losing bits. Fixed
this by doing the cast after the shift (as is done elsewhere in the code).

Signed-off-by: Andre Renaud <andre@bluewatersys.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: David Woodhouse <dwmw2@infradead.org>

parent 340ea370

drivers/mtd/nand/nand_base.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -350,7 +350,7 @@ static int nand_default_block_markbad(struct mtd_info *mtd, loff_t ofs)
		int block, ret;

		/* Get block number */
		block = ((int)ofs) >> chip->bbt_erase_shift;
		block = (int)(ofs >> chip->bbt_erase_shift);
		if (chip->bbt)
		chip->bbt[block >> 2] \|= 0x01 << ((block & 0x03) << 1);

Admin message