Commit 42248a91 authored Jul 01, 2019 by Colin Ian King Committed by Ulf Hansson Jul 10, 2019

mmc: alcor: remove a redundant greater or equal to zero comparison



A greater or equal comparison on the unsigned int variable tmp_diff
is always true as unsigned ints are never negative.  Hence the
comparison is redundant and can be removed.

Addresses-Coverity: ("Unsigned compared against 0")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

parent 5e6b6651

drivers/mmc/host/alcor.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -672,7 +672,7 @@ static void alcor_set_clock(struct alcor_sdmmc_host *host, unsigned int clock)
		tmp_clock = DIV_ROUND_UP(cfg->clk_src_freq, tmp_div);
		tmp_diff = abs(clock - tmp_clock);

		if (tmp_diff >= 0 && tmp_diff < diff) {
		if (tmp_diff < diff) {
		diff = tmp_diff;
		clk_src = cfg->clk_src_reg;
		clk_div = tmp_div;

Admin message