tracing, mei: Remove unused trace event mei_pci_cfg_write (421eb12e) · Commits · 戴 / test

Commit ("mei: trace pci configuration space io") added the trace event mei_pci_cfg_write but never used it. As trace events that are defined take up space for data structures and functions created for them, it is a waste of memory to have one defined but not used. Remove this trace event. Signed-off-by:

Steven Rostedt (VMware) <rostedt@goodmis.org> Signed-off-by:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>

drivers/misc/mei/mei-trace.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -23,5 +23,4 @@
		EXPORT_TRACEPOINT_SYMBOL(mei_reg_read);
		EXPORT_TRACEPOINT_SYMBOL(mei_reg_write);
		EXPORT_TRACEPOINT_SYMBOL(mei_pci_cfg_read);
		EXPORT_TRACEPOINT_SYMBOL(mei_pci_cfg_write);
		#endif /* __CHECKER__ */

drivers/misc/mei/mei-trace.h

+0 −19

Original line number	Diff line number	Diff line
		@@ -83,25 +83,6 @@ TRACE_EVENT(mei_pci_cfg_read,
		__get_str(dev), __entry->reg, __entry->offs, __entry->val)
		);

		TRACE_EVENT(mei_pci_cfg_write,
		TP_PROTO(const struct device dev, const char reg, u32 offs, u32 val),
		TP_ARGS(dev, reg, offs, val),
		TP_STRUCT__entry(
		__string(dev, dev_name(dev))
		__field(const char *, reg)
		__field(u32, offs)
		__field(u32, val)
		),
		TP_fast_assign(
		__assign_str(dev, dev_name(dev))
		__entry->reg = reg;
		__entry->offs = offs;
		__entry->val = val;
		),
		TP_printk("[%s] pci cfg write %s[%#x] = %#x",
		__get_str(dev), __entry->reg, __entry->offs, __entry->val)
		);

		#endif /* _MEI_TRACE_H_ */

		/* This part must be outside protection */

Admin message